macho: Pass sections by pointer when slicing names #12175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were accidentally returning a pointer to stack memory, because these arguments were passed by value. It's just an accident that stage 1 was passing these by reference, so things were alright until stage 3.
|
Nice find! I think an important language goal will be having safety for this kind of problem. Possibly by changing aliasing rules and possibly by doing something along the lines of #3180 (comment). |
|
Big +1 I have some other crazy ideas in the space I want to try out at some point - Looking forward to the experimental phase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought these were fishy in the debug(link) logs:
Turns out, we were accidentally returning a pointer to a parameter - Stage 1 just happened to pass the parameter by reference.
stage3/bin/zig build-exe test3.zig -target x86_64-macos-noneworks on my machine now.One more stepping stone for #12111