macho: fail if requested -framework is not found

[motiejus]

If -framework is requested, but not found, the linker will err
instead of creating a strange executable.

#10299 (comment)

Refs #9542
Refs #10299
Refs #10158

[kubkon]

Thanks @motiejus! Do you mind if I add a few tweaks to your proposed solution? Namely, I don't want the linker fail prematurely until it resolves all of the symbols first, and then the priority should be to fail with UndefinedSymbolReference before failing with FrameworkNotFound. This should give the user a better idea what symbols were unresolved if any. In case we are able to resolve every symbol but fail to find a framework that might be used at runtime, we then fail with FrameworkNotFound.

[motiejus]

Thanks @motiejus! Do you mind if I add a few tweaks to your proposed solution? Namely, I don't want the linker fail prematurely until it resolves all of the symbols first, and then the priority should be to fail with UndefinedSymbolReference before failing with FrameworkNotFound. This should give the user a better idea what symbols were unresolved if any. In case we are able to resolve every symbol but fail to find a framework that might be used at runtime, we then fail with FrameworkNotFound.

Sure, that sounds like a great improvement!