-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secp256k1 scalar multiplication panics #15267
Labels
bug
Observed behavior contradicts documented or intended behavior
standard library
This issue involves writing Zig code for the standard library.
Milestone
Comments
guidovranken
added
the
bug
Observed behavior contradicts documented or intended behavior
label
Apr 13, 2023
Not sure about this but it seems an exception is more appropriate? |
jedisct1
added a commit
to jedisct1/zig
that referenced
this issue
Apr 13, 2023
jedisct1
added a commit
to jedisct1/zig
that referenced
this issue
Apr 13, 2023
jedisct1
added a commit
to jedisct1/zig
that referenced
this issue
Apr 13, 2023
Thank you Guido! Yes, we check everywhere that inputs are in canonical form, so returning an error is the right thing to do, and doesn't cost extra CPU cycles. |
jedisct1
added a commit
to jedisct1/zig
that referenced
this issue
Apr 13, 2023
1e0d492 should fix it. Thanks! |
andrewrk
added
the
standard library
This issue involves writing Zig code for the standard library.
label
Apr 13, 2023
jedisct1
added a commit
that referenced
this issue
Apr 14, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Observed behavior contradicts documented or intended behavior
standard library
This issue involves writing Zig code for the standard library.
Zig Version
zig-linux-x86_64-0.11.0-dev.2560+602029bb2
Steps to Reproduce and Observed Behavior
Expected Behavior
No panic, but an exception which is caught by the invocation to
mulPublic
.The text was updated successfully, but these errors were encountered: