Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zig.trace.server doesn't send the correct value in LSP messages #99

Closed
kcbanner opened this issue Apr 16, 2023 · 1 comment · Fixed by #167
Closed

zig.trace.server doesn't send the correct value in LSP messages #99

kcbanner opened this issue Apr 16, 2023 · 1 comment · Fixed by #167
Labels
lsp Issue with language server integration

Comments

@kcbanner
Copy link

I was implementing setTrace in zls, and I noticed this. VSCode seems to always send "trace": "off" regardless of the "zig.trace.server" setting.
@SuperAuguste
Copy link
Collaborator

Used to work in zls-vscode and I think the reason is that the language client name matched the config name here https://github.com/ziglang/vscode-zig/blob/master/src/zls.ts#L153. Maybe changing this to zig will help? VSCode is supposed to handle this for us automatically. :/

@kcbanner kcbanner mentioned this issue Apr 16, 2023
Merged
@Vexu Vexu added the lsp Issue with language server integration label May 30, 2023
@alexrp alexrp mentioned this issue Jan 15, 2024
Merged
@Vexu Vexu closed this as completed in #167 Jan 16, 2024
Vexu pushed a commit that referenced this issue Jan 16, 2024
@alexrp @Vexu
Use zig.zls as the language client ID and rename trace setting acco…
c97caeb 
…rdingly.

Closes #99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lsp Issue with language server integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use zig.zls as the language client ID and rename trace setting accordingly.
3 participants
@kcbanner @Vexu @SuperAuguste