Feature - Add webpack to bundle assets

[pratikborsadiya]

This pull request aims to utilise webpack module bundler to bundle JavaScript and CSS files required for the project.

[pratikborsadiya]

@ziahamza This feature is good to go. If there is anything else which requires modification or fixing let me know.

[pratikborsadiya]

@anthonyraymond will you help me update the docker configuration if needed for this PR as the index.html file's location is changed from project root directory to build directory I assume some of the docker configurations may need updating as well.

[anthonyraymond]

Sure :) i'll do it asap

[ziahamza]

@pratikborsadiya so the only thing I am worried about is that this is published through github pages. So going to ziahamza.github.io/webui-aria2 leads to build in master and a few people use it.

One alternative we can do, is to still have an index.html page and redirect them to build directly? or perhaps we can deploy our master through netlify to a subdomain, and redirect from index.html to that sub domain that auto builds from master?

[pratikborsadiya]

The other thing we can do is to rename the build folder to docs and GitHub pages can render index.html file from docs folder. I am already doing it for one of my open-source project vali-admin. What do you think?

[anthonyraymond]

@pratikborsadiya @ziahamza i'll wait for a decision on the github-pages thing before i change the dockerfile then

[ziahamza]

Agreed @pratikborsadiya . lets do the re-name to /docs. And then perhaps later we can think about auto-publishing either on Netlify or perhaps have CI pre-build and publish to gh-pages

[pratikborsadiya]

@anthonyraymond I have updated the build process to create docs folder. You can proceed to update the docker configuration.

[anthonyraymond]

I have absolutely no idea why is this happening but i got this error message:

However the Webui seems to work flawlessly.

If that can help, it runs behind a webproxy (SSL enabled).

[pratikborsadiya]

@anthonyraymond This issue is happening because of the web-server running inside docker container is responding javascript files with Content-type response header as application/octet-stream which should be application/javascript for all the javascript files.

[pratikborsadiya]

@ziahamza You can merge the pull request as the issue mentioned by @anthonyraymond can be solved in a separate PR and will not affect the functionality of WebUI itself. The only thing which will not work in docker environment is the ability to open the WebUI when the browser is offline.

[ziahamza]

Agreed @pratikborsadiya

[pratikborsadiya]

@ziahamza don't forget to change the github pages root from settings.

[ziahamza]

Done :)

…

On Sep 8, 2018, at 6:21 PM, Pratik Borsadiya ***@***.***> wrote: @ziahamza <https://github.com/ziahamza> don't forget to change the github pages root from settings. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#467 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMnMMRCCu-LhIMnN24hhkBYvoBxST67ks5uY5oQgaJpZM4WT9oP>.

[pratikborsadiya]

Are you sure you have selected master branch /docs folder option in gihub pages source dropdown because right now https://ziahamza.github.io/webui-aria2/ is showing readme file instead of showing the WebUI.

[ziahamza]

May take a few minutes:

[pratikborsadiya]

@ziahamza You'll have to push a commit to master branch for GitHub pages to change the website root and build your site again. The way GitHub pages work is that they will build your pages site on every commit. You must have changed the setting to build from docs after you merged the PR. So the root will not change to docs folder until you push a commit to master and and GitHub pages will rebuild your site. I have just got to know about this by experimenting with my own project vali-admin.