use updated var from hf refactor#77
Merged
Merged
Conversation
Contributor
Author
|
@zhuzilin Would you be able to review and push a new release with this pls? |
Owner
|
Sorry for the wait. I've pushed a new release. Thank you :) |
eric-tc-wong
pushed a commit
to aqlaboratory/ring-flash-attention
that referenced
this pull request
Sep 17, 2025
eric-tc-wong
added a commit
to aqlaboratory/ring-flash-attention
that referenced
this pull request
Sep 17, 2025
This reverts commit fc6f22d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
huggingface/transformers#39474 refactored the
_flash_supports_window_sizevariable namewe had to do a similar fix in axolotl-ai-cloud/axolotl#2966, but we still import ring-flash-attn, so we need this change as well to use latest transformers.