Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugsList #3

Open
2 tasks
zhongdeming428 opened this issue Dec 15, 2018 · 5 comments
Open
2 tasks

BugsList #3

zhongdeming428 opened this issue Dec 15, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@zhongdeming428
Copy link
Owner

zhongdeming428 commented Dec 15, 2018

  • 应当新增一个抛出函数参数不合法错误的 util 函数,减少重复代码。
  • keys 方法需要兼容 IE <= 9
@zhongdeming428 zhongdeming428 added the bug Something isn't working label Dec 15, 2018
@KarthusLorin
Copy link
Contributor

@zhongdeming428 我发现有部分错别字,需要另拉分支修改吗?

@zhongdeming428
Copy link
Owner Author

@KarthusLorin 如果可以的话,感激不尽:rose:

@KarthusLorin
Copy link
Contributor

@zhongdeming428 isPlainObjectisObjectzhee 这两个函数我感觉有更好的实现方法,可以按照vue源码中的实现方式来实现,我明天有空改改吧~

@KarthusLorin
Copy link
Contributor

@zhongdeming428 我发现很多地方没有遵循 eslint 的规则,个人认为需要定一个 eslint 规则,比如函数括号后要不要加空格之类的,或者直接使用 airbnb 的规则?

@zhongdeming428
Copy link
Owner Author

@KarthusLorin isPlainObject 是参照 redux 方案实现的,不知道 Vue 是怎么实现的,你可以试试看。另外 eslint 之前设置了规则,但是 npm 脚本没设置好,写成了只校验 src/index.js,所以其他模块没校验到:cry:。现在修改了脚本,能够校验了,另外有问题的代码我也修复了。规则不用改,现在能够校验到。

zhongdeming428 pushed a commit that referenced this issue Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants