Skip to content

Conversation

@zhiyuanliang-ms
Copy link
Owner

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copy link

@sebastienros sebastienros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also need some unit tests once this is targeting the aspire repos.

@zhiyuanliang-ms zhiyuanliang-ms marked this pull request as ready for review March 31, 2025 09:38
@zhiyuanliang-ms zhiyuanliang-ms force-pushed the zhiyuanliang/app-config-component branch from a792085 to 316eb9d Compare April 1, 2025 07:16
@zhiyuanliang-ms
Copy link
Owner Author

Move to #8459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants