Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade PT to 1.9.0 in unit-test #161

Merged
merged 7 commits into from
Sep 10, 2021
Merged

Conversation

zhiqwang
Copy link
Owner

@zhiqwang zhiqwang commented Sep 10, 2021

To simplify the unit-tests, we upgraded the PT to 1.9.0, but the core functionality of this package is workable on PT 1.7.0 and above.

@zhiqwang zhiqwang added the enhancement New feature or request label Sep 10, 2021
@zhiqwang zhiqwang mentioned this pull request Sep 10, 2021
9 tasks
@zhiqwang zhiqwang changed the title Add ultralytics alignment unit-tests Upgrade PT to 1.9.0 in unit-test Sep 10, 2021
@zhiqwang zhiqwang added code quality Code format and unit tests and removed code quality Code format and unit tests enhancement New feature or request labels Sep 10, 2021
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #161 (f572c53) into master (b6d8e00) will increase coverage by 11.97%.
The diff coverage is 91.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #161       +/-   ##
===========================================
+ Coverage   84.22%   96.20%   +11.97%     
===========================================
  Files          12       10        -2     
  Lines         748      553      -195     
===========================================
- Hits          630      532       -98     
+ Misses        118       21       -97     
Flag Coverage Δ
unittests 96.20% <91.73%> (+11.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_models.py 94.87% <89.58%> (-5.13%) ⬇️
test/test_data_pipeline.py 100.00% <100.00%> (ø)
test/test_engine.py 100.00% <100.00%> (ø)
test/test_image_utils.py 100.00% <100.00%> (ø)
test/test_models_anchor_utils.py 100.00% <100.00%> (ø)
test/test_models_common.py 100.00% <100.00%> (ø)
test/test_models_transform.py 100.00% <100.00%> (ø)
test/test_onnx.py 85.24% <100.00%> (-0.47%) ⬇️
test/test_utils.py 88.88% <100.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d8e00...f572c53. Read the comment docs.

@zhiqwang zhiqwang merged commit 96562f0 into master Sep 10, 2021
@zhiqwang zhiqwang deleted the ultralytics-alignment-test branch September 10, 2021 11:03
@zhiqwang zhiqwang added the dependencies Pull requests that update a dependency file label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code format and unit tests dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant