Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AnchorGenerator will use dtype of input feature_maps #111

Merged
merged 1 commit into from
May 21, 2021

Conversation

dkloving
Copy link
Contributor

AnchorGenerator.grid_anchors had fp32 hard-coded which could result in forward pass returning mismatched datatypes, for example (fp32, fp16, fp16).

Fix for #107

AnchorGenerator.grid_anchors had fp32 hard-coded which could result in forward pass returning mismatched datatypes, for example (fp32, fp16, fp16).

Fix for zhiqwang#107
@zhiqwang zhiqwang added the enhancement New feature or request label May 21, 2021
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #111 (a673434) into master (218c428) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files           8        8           
  Lines         784      784           
=======================================
  Hits          655      655           
  Misses        129      129           
Flag Coverage Δ
unittests 83.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 218c428...a673434. Read the comment docs.

Copy link
Owner

@zhiqwang zhiqwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhiqwang
Copy link
Owner

@dkloving , Thanks a lot for the investigation and PR.!

@zhiqwang zhiqwang merged commit b0af4a1 into zhiqwang:master May 21, 2021
@dkloving dkloving deleted the patch-2 branch May 21, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants