[None][chore] gitignore .nfs* temporary NFS system files - #10
Closed
zhenhuaw-me wants to merge 1 commit into
Closed
zhenhuaw-me wants to merge 1 commit into
zhenhuaw-me wants to merge 1 commit into
Conversation
They are temporary NFS system files
zhenhuaw-me
added a commit
that referenced
this pull request
May 29, 2026
… use stock ValueError Per self-review feedback on PR NVIDIA#14733: no custom exception layer on top of Python's standard error types. Validation failures now raise plain ``ValueError`` with the same multi-line message; the structured ``reason`` / ``param`` / ``details`` fields are removed. Core changes - Remove ``VisualGenValidationError`` class and the ``Literal`` / ``field`` imports it required. - Replace ``DiffusionResponse.error_reason`` / ``error_param`` / ``error_details`` with a single ``is_validation_error: bool`` discriminator. Same on ``VisualGenOutput``. The coordinator-side awaiter uses it to re-raise as ``ValueError`` (-> HTTP 400) vs ``RuntimeError`` (-> HTTP 500); routes catch the standard types directly and no longer import the custom class. - ``validate_visual_gen_params`` raises ``ValueError`` with the multi-line per-violation message. The per-category accumulator lists feeding into ``details`` are gone; the flat ``messages`` list builds the same human-readable content. Fix the "silently ignored" wording on the universal-field branch since that branch does raise. - READY signal now propagates ``pipeline_name`` so coordinator-side pre-validation uses the actual loaded pipeline's class name (was always "VisualGen"). Closes the worker/coordinator parity gap that CodeRabbit #10 flagged. Cascade (all driven by the drop) - Remove ``VisualGen.validate_request_params`` method. Async video route calls module-level ``validate_visual_gen_params`` directly with the propagated executor metadata. - ``VisualGenResult._resolved_value`` dispatches on ``out.is_validation_error`` (ValueError vs RuntimeError). - Sync image, sync video, and async video routes drop their ``except VisualGenValidationError`` arm; the existing ``except ValueError`` arm handles validation failures the same way (HTTP 400 + message). Tests - ``TestVisualGenValidationErrorStructured`` -> ``TestValidateVisualGenParamsMessages``: assert ``ValueError`` with expected substrings instead of structured fields. - ``TestValidationErrorTransport`` switches to asserting ``is_validation_error``. - ``TestRouteVisualGenValidationError`` -> ``TestRouteEngineValidationError``: sync routes inject a stock ``ValueError`` on the mock; async route triggers a real validator rejection by sending an unknown extra_params key against the mock's executor metadata. - ``MockVisualGen`` gains an ``executor`` ``SimpleNamespace`` with ``pipeline_name`` / ``default_generation_params`` / ``extra_param_specs`` so the async pre-flight call works end-to-end. Verified on GB200: full visual_gen unit subsystem 357 passed / 0 failed in 60.67s. Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
zhenhuaw-me
added a commit
that referenced
this pull request
May 29, 2026
… use stock ValueError Per self-review feedback on PR NVIDIA#14733: no custom exception layer on top of Python's standard error types. Validation failures now raise plain ``ValueError`` with the same multi-line message; the structured ``reason`` / ``param`` / ``details`` fields are removed. Core changes - Remove ``VisualGenValidationError`` class and the ``Literal`` / ``field`` imports it required. - Replace ``DiffusionResponse.error_reason`` / ``error_param`` / ``error_details`` with a single ``is_validation_error: bool`` discriminator. Same on ``VisualGenOutput``. The coordinator-side awaiter uses it to re-raise as ``ValueError`` (-> HTTP 400) vs ``RuntimeError`` (-> HTTP 500); routes catch the standard types directly and no longer import the custom class. - ``validate_visual_gen_params`` raises ``ValueError`` with the multi-line per-violation message. The per-category accumulator lists feeding into ``details`` are gone; the flat ``messages`` list builds the same human-readable content. Fix the "silently ignored" wording on the universal-field branch since that branch does raise. - READY signal now propagates ``pipeline_name`` so coordinator-side pre-validation uses the actual loaded pipeline's class name (was always "VisualGen"). Closes the worker/coordinator parity gap that CodeRabbit #10 flagged. Cascade (all driven by the drop) - Remove ``VisualGen.validate_request_params`` method. Async video route calls module-level ``validate_visual_gen_params`` directly with the propagated executor metadata. - ``VisualGenResult._resolved_value`` dispatches on ``out.is_validation_error`` (ValueError vs RuntimeError). - Sync image, sync video, and async video routes drop their ``except VisualGenValidationError`` arm; the existing ``except ValueError`` arm handles validation failures the same way (HTTP 400 + message). Tests - ``TestVisualGenValidationErrorStructured`` -> ``TestValidateVisualGenParamsMessages``: assert ``ValueError`` with expected substrings instead of structured fields. - ``TestValidationErrorTransport`` switches to asserting ``is_validation_error``. - ``TestRouteVisualGenValidationError`` -> ``TestRouteEngineValidationError``: sync routes inject a stock ``ValueError`` on the mock; async route triggers a real validator rejection by sending an unknown extra_params key against the mock's executor metadata. - ``MockVisualGen`` gains an ``executor`` ``SimpleNamespace`` with ``pipeline_name`` / ``default_generation_params`` / ``extra_param_specs`` so the async pre-flight call works end-to-end. Verified on GB200: full visual_gen unit subsystem 357 passed / 0 failed in 60.67s. Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
zhenhuaw-me
added a commit
that referenced
this pull request
Jun 1, 2026
… use stock ValueError Per self-review feedback on PR NVIDIA#14733: no custom exception layer on top of Python's standard error types. Validation failures now raise plain ``ValueError`` with the same multi-line message; the structured ``reason`` / ``param`` / ``details`` fields are removed. Core changes - Remove ``VisualGenValidationError`` class and the ``Literal`` / ``field`` imports it required. - Replace ``DiffusionResponse.error_reason`` / ``error_param`` / ``error_details`` with a single ``is_validation_error: bool`` discriminator. Same on ``VisualGenOutput``. The coordinator-side awaiter uses it to re-raise as ``ValueError`` (-> HTTP 400) vs ``RuntimeError`` (-> HTTP 500); routes catch the standard types directly and no longer import the custom class. - ``validate_visual_gen_params`` raises ``ValueError`` with the multi-line per-violation message. The per-category accumulator lists feeding into ``details`` are gone; the flat ``messages`` list builds the same human-readable content. Fix the "silently ignored" wording on the universal-field branch since that branch does raise. - READY signal now propagates ``pipeline_name`` so coordinator-side pre-validation uses the actual loaded pipeline's class name (was always "VisualGen"). Closes the worker/coordinator parity gap that CodeRabbit #10 flagged. Cascade (all driven by the drop) - Remove ``VisualGen.validate_request_params`` method. Async video route calls module-level ``validate_visual_gen_params`` directly with the propagated executor metadata. - ``VisualGenResult._resolved_value`` dispatches on ``out.is_validation_error`` (ValueError vs RuntimeError). - Sync image, sync video, and async video routes drop their ``except VisualGenValidationError`` arm; the existing ``except ValueError`` arm handles validation failures the same way (HTTP 400 + message). Tests - ``TestVisualGenValidationErrorStructured`` -> ``TestValidateVisualGenParamsMessages``: assert ``ValueError`` with expected substrings instead of structured fields. - ``TestValidationErrorTransport`` switches to asserting ``is_validation_error``. - ``TestRouteVisualGenValidationError`` -> ``TestRouteEngineValidationError``: sync routes inject a stock ``ValueError`` on the mock; async route triggers a real validator rejection by sending an unknown extra_params key against the mock's executor metadata. - ``MockVisualGen`` gains an ``executor`` ``SimpleNamespace`` with ``pipeline_name`` / ``default_generation_params`` / ``extra_param_specs`` so the async pre-flight call works end-to-end. Verified on GB200: full visual_gen unit subsystem 357 passed / 0 failed in 60.67s. Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.