[config_mgmt.py]: Separate class for Dy Port BreakOut and support ext… #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasant17
reviewed
May 26, 2020
vasant17
reviewed
May 26, 2020
vasant17
reviewed
May 26, 2020
vasant17
reviewed
May 26, 2020
vasant17
reviewed
May 26, 2020
vasant17
approved these changes
May 26, 2020
|
@praveen-li @vasant17 Please resolve all the conversations before we approve/merge the PR. |
|
@praveen-li We need add Yang models for BREAKOUT_CFG table, or we skip this table check in ConfigMgmtDPB class, so to avoid the confirmation ask as we know that is expected. |
zhenggen-xu
reviewed
May 27, 2020
added 3 commits
June 29, 2020 17:15
…ra config tables listing. Changes: 1.) Added a new class for ConfigMgmtDPB, which is derived from ConfigMgmt. 2.) Support to list extra tables in config. 3.) Search keys in config. This is need to list port related config in extra tables. 4.) Separate loadData function in ConfigMgmt class. Signed-off-by: Praveen Chaudhary [email protected]
Signed-off-by: Praveen Chaudhary [email protected]
…ablesWithOutYang too. Signed-off-by: Praveen Chaudhary [email protected]
praveen-li
force-pushed
the
handle_tables_without_yang
branch
from
e622bb3 to
efbcc3b
Compare
|
@vasant17 @zhenggen-xu Conflict resolved, Kindly merge. I do not have merge permissions for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ra config tables listing.
Changes:
1.) Added a new class for ConfigMgmtDPB, which is derived from ConfigMgmt.
2.) Support to list extra tables in config.
3.) Search keys in config. This is need to list port related config in extra tables.
4.) Separate loadData function in ConfigMgmt class.
Signed-off-by: Praveen Chaudhary [email protected]
- What I did
1.) Added a new class for ConfigMgmtDPB, which is derived from ConfigMgmt.
2.) Support to list extra tables in config.
3.) Search keys in config. This is need to list port related config in extra tables.
4.) Separate loadData function in ConfigMgmt class.
- How I did it
0.) zhenggen-xu/sonic-buildimage#69 to store extra tables.
1.) Added a new class for ConfigMgmtDPB, which is derived from ConfigMgmt.
2.) Support to list extra tables in config.
3.) Search keys in config. This is need to list port related config in extra tables.
4.) Separate loadData function in ConfigMgmt class.
- How to verify it
Ran below Tests
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)