[sonic-yang-models/yang-models/sonic-acl.yang]: Make type mandatory a… #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd add default value of stage. Changes: -- Make type mandatory and add default value of stage. -- Test case. -- Support for Verification in data tree. Signed-off-by: Praveen Chaudhary [email protected]
|
@vasant17 REview when possible. |
|
@praveen-li Can you add the test results in the build log to the PR? |
li-pingmao
reviewed
Jun 26, 2020
li-pingmao
reviewed
Jun 26, 2020
Signed-off-by: Praveen Chaudhary [email protected] RB= G=lnos-reviewers R=pchaudhary,pmao,rmolina,samaity,sfardeen,zxu A=
li-pingmao
approved these changes
Jun 26, 2020
vasant17
reviewed
Jun 26, 2020
vasant17
approved these changes
Jun 26, 2020
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 12, 2020
…nic-net#5103) * src/sonic-platform-common be1cc24...f3f3573 (3): > Remove sonic-config-engine dependency from setup.py (sonic-net#109) > Migrate from sonic-daemon-base package to sonic-py-common package (sonic-net#103) > [Cables] Add support for 'Extended Specification Compliance' for QSFP cables (sonic-net#108) > [sfputilbase.py] Add application_advertisement NA field to transceiver_info_dict for platform api 1.0 (sonic-net#104) * src/sonic-platform-daemons 49d145c...8e0704e (1): > Proper fix for thermalctld using sonic-py-common (zhenggen-xu#80) > Fix thermalctld tests which were broken by the transition to sonic-py-common (zhenggen-xu#79) > Migrate from sonic-daemon-base package to sonic-py-common package (zhenggen-xu#74)
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Oct 9, 2020
zhenggen-xu#80) * [sonic-yang-models/yang-models/sonic-acl.yang]: Make type mandatory and add default value of stage. Changes: -- Make type mandatory and add default value of stage. -- Test case. -- Support for Verification in data tree. Signed-off-by: Praveen Chaudhary [email protected]
zhenggen-xu
pushed a commit
that referenced
this pull request
Dec 15, 2020
Commits on Mar 20, 2020 SFP(sff8472 attributes) transciever eeprom attribute support. (#74) 9b1dea5 Commits on Mar 22, 2020 Detect an SFP adapter in a QSFP port, and instantiate an SFP object i… 116eeec Commits on Apr 13, 2020 [component]: Introduce new firmware management API. 2632a59 Commits on Apr 16, 2020 [Chassis base] Add sfp error event definition (#80) f1f00ec Commits on Apr 24, 2020 [component]: Update firmware management API. 777901f [component]: Extend docstrings for firmware management API. b066ec7 Commits on Apr 30, 2020 [component]: Fix review comments. d96344e Merge pull request #82 from nazariig/master-component-firmware-api 28c39c5 Signed-off-by: Nazarii Hnydyn <[email protected]>
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Apr 27, 2021
Feb 17 Fix tests failing due to duplicate vxlan tunnel creation (zhenggen-xu#75) Mar 11 Update route api to specify limitation (zhenggen-xu#77) Apr 01 Add host_ifname field while adding entry in VLAN table (zhenggen-xu#80)
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Jul 28, 2021
Feb 17 Fix tests failing due to duplicate vxlan tunnel creation (zhenggen-xu#75) Mar 11 Update route api to specify limitation (zhenggen-xu#77) Apr 01 Add host_ifname field while adding entry in VLAN table (zhenggen-xu#80)
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 9, 2022
e56e9b4 Fix CVE-2021-3121 warning (sonic-net#96) bf1be4f [ci]: Support code diff coverage threshold 50% (zhenggen-xu#94) 64e516c Ported Marvell armhf build on x86 for debian buster to use cross-compilation instead of qemu emulation (zhenggen-xu#80) e426388 [ci]: Support azp code coverage (zhenggen-xu#87)
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Aug 9, 2022
[sonic-linkmgrd][master] Submodule Update 9c8a16e Jing Zhang Sun Jun 5 08:27:07 2022 -0700 Separate I2C mux state probing and gRPC forwarding state probing (zhenggen-xu#86) 491c4ee Longxiang Lyu Sun Jun 5 23:26:19 2022 +0800 Fix peer mux wait back off factor (zhenggen-xu#84) a0b6b14 Jing Zhang Wed Jun 1 10:33:12 2022 -0700 Revert "Update log level for mux probing and mux state chance (zhenggen-xu#23)" (zhenggen-xu#85) 3c2b546 Jing Zhang Tue May 31 10:14:42 2022 -0700 Add default route support to active-active state machine (zhenggen-xu#78) 6fa892e Longxiang Lyu Fri May 27 09:15:06 2022 +0800 Degrade LinkProberStateMachineBase virtual function logging level (zhenggen-xu#80) 7b695ca Longxiang Lyu Fri May 27 09:14:02 2022 +0800 Fix mux wait timer and peer mux wait timer (zhenggen-xu#81)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd add default value of stage for sonic-acl.yang.
Changes:
-- Make type mandatory and add default value of stage.
-- Test case.
-- Support for Verification in data tree.
Signed-off-by: Praveen Chaudhary [email protected]
- What I did
Changes:
-- Make type mandatory and add default value of stage for sonic-acl.yang.
-- New Test case.
-- Support for Verification in data tree.
- How I did it
Get the data tree using ly.LYP_WD_ALL option, so that default fields are populated.
- How to verify it
built all relevant PKGs.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)