add mkldnn surport for concat #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wentingj could you run "make lint" and fix the coding style, please? Thanks. |
|
@zheng-da Thanks for your kind reminder. I have run "make lint" and passed coding style checking in my branch "wentingj:mkldnn-concat". |
zheng-da
approved these changes
Dec 8, 2017
| std::vector<nnvm::NodeEntry> heads(ograds.begin(), ograds.end()); | ||
| for (size_t i = 0; i < n->inputs.size(); i++) { |
There was a problem hiding this comment.
this makes native concat fail. The native concat only expects out_grad.
xinyu-intel
pushed a commit
to wentingj/incubator-mxnet-int8
that referenced
this pull request
May 6, 2018
* Updated tutorials page. * Combined tutorial links Added "alternative" links. * Corrected typo * Force build. * Force build zheng-da#2 * Force build zheng-da#3 * Force zheng-da#4
jinhuang415
pushed a commit
to jinhuang415/incubator-mxnet
that referenced
this pull request
May 29, 2018
* Updated tutorials page. * Combined tutorial links Added "alternative" links. * Corrected typo * Force build. * Force build zheng-da#2 * Force build zheng-da#3 * Force zheng-da#4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add mkldnn surport for concat, which passed unit test. First epoch of inception-bn has "Epoch[0] Train-accuracy=0.573438"
Checklist
Essentials
make lint)Changes
Comments