fix(windows): add OSError to os.kill and UTF-8 encoding to file reads - #2
Open
zhanggttry wants to merge 35 commits into
Open
zhanggttry wants to merge 35 commits into
zhanggttry wants to merge 35 commits into
Conversation
Empty push to re-trigger CI after branch rebuild.
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-import |
3 |
unresolved-reference |
1 |
unresolved-attribute |
1 |
First entries
hermes_cli/send_cmd.py:219: [unresolved-import] unresolved-import: Cannot resolve imported module `dotenv`
gateway/run.py:17078: [unresolved-import] unresolved-import: Module `gateway` has no member `memory_monitor`
hermes_cli/auth.py:4447: [unresolved-reference] unresolved-reference: Name `Tuple` used when not defined: Did you mean `tuple`?
tools/process_registry.py:560: [unresolved-attribute] unresolved-attribute: Module `subprocess` has no member `CREATE_NO_WINDOW`
gateway/run.py:8671: [unresolved-import] unresolved-import: Cannot resolve imported module `hermes_cli.session_recap`
✅ Fixed issues: none
Unchanged: 4390 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
…gateway/status.py
…hermes_cli/banner.py
…hermes_cli/doctor.py
…hermes_cli/main.py
…hermes_cli/web_server.py
…tools/process_registry.py
- Add zhanggttry@163.com to AUTHOR_MAP in scripts/release.py - Sync hermes_cli/send_cmd.py from upstream (missing module caused ~30 test failures) - Remove spurious CI trigger comment from .gitignore Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The newly synced send_cmd.py module exposes a `send` subcommand, but it was missing from the _BUILTIN_SUBCOMMANDS frozenset used by plugin discovery. This caused test_startup_plugin_gating to fail. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes NousResearch#13587. Adds OSError handling to os.kill calls and UTF-8 encoding to file reads for Windows compatibility.