simplify: Add input & output error to simplifySloppy #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes simplifySloppy interface match that of simplify, so that an error limit can be specified up front, and the resulting error is returned when requested. As a consequence, simplifySloppy can no longer guarantee that the output will be at or under the requested triangle count; this unifies the interface between simplify & simplifySloppy further and gives us some opportunity to compute triangle count in a more approximate way in the future. As a result we may need to compute the triangle count for the min. grid size before simplification starts; this sometimes increases the number of passes we need to do by 1, but in aggregate actually *decreases* the number of passes as the interpolation search gets more data and can be more precise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes simplifySloppy interface match that of simplify, so
that an error limit can be specified up front, and the resulting error
is returned when requested.
As a consequence, simplifySloppy can no longer guarantee that the output
will be at or under the requested triangle count; this unifies the
interface between simplify & simplifySloppy further and gives us some
opportunity to compute triangle count in a more approximate way in the
future.
As a result we may need to compute the triangle count for the min. grid
size before simplification starts; this sometimes increases the number
of passes we need to do by 1, but in aggregate actually decreases the
number of passes as the interpolation search gets more data and can be
more precise.
Fixes #112.