When proxying requests to a hub use piping unless told not to. #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
AdamMagaluk
added a commit
that referenced
this pull request
Dec 18, 2015
When proxying requests to a hub use piping unless told not to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
proxyToPeercode inhttp_server.jsto pipe the response body back to the client unless specifically told not to byenv.proxyOptswhich is only used for cross server device queries.Also removes the need to keep the res in
httpServer.clientsI think this was leftover from some earlier code but unnecessary when we have theenv.responseobject in scope.