-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Katana Added #216
base: main
Are you sure you want to change the base?
Draft: Katana Added #216
Conversation
You can Run Katana as : 'go run . --mode=<docker/uv/no-uv> <name-of-the-pipeline>' example: 'go run . --mode=docker abcd'
DOCKER VERSION IS STILL HARD CODED.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The go.sum files seems to be missing from this MR.
Katana/main.go
Outdated
|
||
} | ||
|
||
// TRYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left over comment
|
||
result, err := execution(make(Dict)) | ||
if err != nil { | ||
log.Println("Error from line 282:", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error explanation should be more descriptive than the line number
@@ -0,0 +1,102 @@ | |||
package main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema.go should be shared between anvil and katana to avoid having to keep track of the same schema twice
Katana/entrypoint.py
Outdated
if os.path.exists(requirements_file): | ||
print("Installing dependencies inside UV environment...") | ||
try: | ||
print("HERE>>>") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover print
Katana with multiple parameters, less prints and dynamic outputs.
No description provided.