Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Katana Added #216

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Draft: Katana Added #216

wants to merge 8 commits into from

Conversation

TeerthaDeb
Copy link
Contributor

No description provided.

You can Run Katana as : 'go run . --mode=<docker/uv/no-uv> <name-of-the-pipeline>'
example: 'go run . --mode=docker abcd'
@jmagoon jmagoon changed the title Katana Added Draft: Katana Added Oct 2, 2024
@plparent plparent self-requested a review October 22, 2024 19:47
Copy link
Member

@plparent plparent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The go.sum files seems to be missing from this MR.

Katana/main.go Outdated

}

// TRYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYYY
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left over comment


result, err := execution(make(Dict))
if err != nil {
log.Println("Error from line 282:", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error explanation should be more descriptive than the line number

@@ -0,0 +1,102 @@
package main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schema.go should be shared between anvil and katana to avoid having to keep track of the same schema twice

if os.path.exists(requirements_file):
print("Installing dependencies inside UV environment...")
try:
print("HERE>>>")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover print

Katana with multiple parameters, less prints and dynamic outputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants