-
Notifications
You must be signed in to change notification settings - Fork 61
chore: update standard contracts to v2 #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe dependency version for "@zetachain/standard-contracts" was updated from the release candidate "2.0.0-rc5" to the stable version "2.0.1" in the Changes
Sequence Diagram(s)No sequence diagrams are generated as the changes are limited to dependency version updates and 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/token/package.json (1)
60-60: Broadened version constraint for @zetachain/standard-contracts
Switching from a fixed RC to^2.0.0allows all future v2.x.x releases. Confirm there are no breaking changes in upcoming minors and regenerate your lockfile to pin the resolved version.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
examples/nft/yarn.lockis excluded by!**/yarn.lock,!**/*.lockexamples/token/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
examples/nft/package.json(1 hunks)examples/token/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: slither (examples/hello, hello.sarif)
- GitHub Check: slither (examples/swap, swap.sarif)
- GitHub Check: slither (examples/call, call.sarif)
🔇 Additional comments (1)
examples/nft/package.json (1)
60-60: Broadened version constraint for @zetachain/standard-contracts
This mirrors the token example’s update—moving to^2.0.0widens compatibility. Ensure CI tests pass against the latest patch and minor releases, then update your lockfile accordingly.
s2imonovic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I realized we need better gas limit defaults so that mint and transfer don't fail. |
Summary by CodeRabbit
.openzeppelinto the ignore list in example projects to prevent tracking of build artifacts.