-
Notifications
You must be signed in to change notification settings - Fork 2
feat: run local commands from commands directory #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fadeev
wants to merge
16
commits into
main
Choose a base branch
from
feat-run-local-commands
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d1dd1e5
commands for testing purposes
fadeev b662d97
added run command
fadeev 0cb413c
refactor
fadeev 26f0588
refactor
fadeev da21e3f
refactor
fadeev 5ec884a
wip
fadeev b3b8a69
wip
fadeev 5bb93c1
wip
fadeev 8a67160
addLocalCommands
fadeev 50391a2
lint
fadeev ec48477
run
fadeev c738200
lint
fadeev 269eaab
disable help
fadeev 256c4e5
Fix import
hernan-clich b08b955
Removed unused line
hernan-clich 8050774
Refactored export
hernan-clich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { Command } from "commander"; | ||
|
|
||
| const main = async () => { | ||
| console.log("Deploying example contract..."); | ||
| }; | ||
|
|
||
| export const deployCommand = new Command("deploy") | ||
| .description("Deploy example contract.") | ||
| .action(main); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import { deployCommand } from "./deploy"; | ||
|
|
||
| // Export commands array for dynamic loading by the CLI | ||
| export default { | ||
| commands: [deployCommand], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { Command } from "commander"; | ||
|
|
||
| export const runCommand = new Command("run") | ||
| .helpCommand(false) | ||
| .description("Run commands from the commands directory"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { Command } from "commander"; | ||
| import fs from "fs/promises"; | ||
| import path from "path"; | ||
|
|
||
| export const addLocalCommands = async (runCommand: Command) => { | ||
| try { | ||
| const commandsPath = path.join(process.cwd(), "commands", "index.ts"); | ||
| await fs.access(commandsPath); | ||
|
|
||
| const module = await import(commandsPath); | ||
| if (module.default?.commands) { | ||
| for (const cmd of module.default.commands) { | ||
| runCommand.addCommand(cmd); | ||
| } | ||
| } | ||
| } catch (error) {} | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do something with this catch block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what we can do. Console logging something every time CLI doesn't find commands can be annoying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no error to catch, then we shouldn't be using the try/catch pattern.