Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix divide by zero in zmq::lb_t::sendpipe #163

Merged
merged 1 commit into from
Jan 28, 2017

Conversation

chutz
Copy link
Contributor

@chutz chutz commented Jan 28, 2017

@bluca
Copy link
Member

bluca commented Jan 28, 2017

In zeromq/libzmq#982 it was mentioned that it's not possible for active to be 0 in that place - what issue are you seeing? Do you have a test case that can reproduce it?

@chutz
Copy link
Contributor Author

chutz commented Jan 28, 2017

@bluca No we do not have a test case. We were getting occasional random crashes in a python app that uses zeromq. As far as we can tell, there must be some sort of race condition that is hard to reach, since it does not happen very often.

The kernel log was showing this message

traps: XXXXXXXXXXX[XXXXXXX] trap divide error ip:66230246c4fa sp:6622bb73d640 error:0 in libzmq.so.5.0.1[662302447000+72000]

That maps in the source code to the line we are changing with this patch. Given the similarity to the previous issue, we figured it must be related.

@bluca bluca merged commit 742e303 into zeromq:master Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants