feat(syncx): add DestroyAll method to Pool for proactive resource cleanup #5192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a
DestroyAll()method to thesyncx.Pooltype to enable proactive destruction of all pooled resources. This addresses scenarios where the existing passivemaxAgemechanism is insufficient for immediate resource cleanup.Problem Statement
When managing dynamic resources (e.g., network connections, client instances) with
syncx.Pool, there was no built-in way to proactively destroy all resources when the pool is no longer needed. The existingmaxAgemechanism only passively cleans up expired resources, which isn't sufficient for scenarios like:Solution
The new
DestroyAll()method provides immediate, complete cleanup of all pooled resources:Implementation Details
head = nil,created = 0)Broadcast()to wake up any goroutines waiting for resourcesDestroyAll(), creating new resources as neededTesting
Added comprehensive test coverage including:
All existing tests pass, ensuring no regressions.
Use Cases
Perfect for scenarios requiring immediate resource cleanup:
Closes #xxxx
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.