Add retryJitter option to add jitter to retryTimeout #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to randomly spread the retryTimeout over a window between retryTimeout ± retryJitter.
shezadkhan137
force-pushed
the
feat/add-retry-jitter
branch
from
a0663c7
to
94eeec2
Compare
Xopherus
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
LGTM! I think we should also consider removing retryTimeout from the NewServer constructor in a future PR (I know that's outside of the scope of this PR).
There's a few minor style concerns I have (mostly re: the wsl linter) but I see that we're pretty out of date in our golangci-lint version, so I will handle upgrading that!
| @@ -260,3 +281,21 @@ func WithRetries(delay time.Duration, max int) Option { | |||
| return nil | |||
| } | |||
| } | |||
|
|
|||
| // WithRetryJitter sets a value for Jitter on the VisibilityTimeout. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to randomly spread the retryTimeout over a window between
retryTimeout ± retryJitter.