Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DefaultRetryer to SNS topics #14

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Add DefaultRetryer to SNS topics #14

merged 2 commits into from
Apr 18, 2018

Conversation

elmarcoh
Copy link
Contributor

No description provided.

@elmarcoh
Copy link
Contributor Author

This is A WIP still

@Xopherus
Copy link
Contributor

I'd like to get this in before we mark another release. Lemme know when this is ready to review @marcrosis !

@elmarcoh
Copy link
Contributor Author

elmarcoh commented Apr 16, 2018 •
edited
Loading

@Xopherus It only needs tests, I'm working on that. ;)

Xopherus
Xopherus approved these changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@Xopherus Xopherus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @marcrosis

@Xopherus Xopherus merged commit 7cfe9fd into zerofox-oss:master Apr 18, 2018
@elmarcoh elmarcoh deleted the sns-retryer branch April 18, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rynmrtn rynmrtn rynmrtn approved these changes

@Xopherus Xopherus Xopherus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elmarcoh @Xopherus @rynmrtn