Updates #13
Merged
Updates #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xopherus
force-pushed
the
updates
branch
2 times, most recently
from
00ca4de
to
5cf1f60
Compare
- It seems like a best practice for libraries is to not vendor any dependencies, so they are removed here - Add govendor to fetch dependencies for tests. When will the Go community decide on the one true package manager?!? - Change lint tool to gometalinter
Xopherus
force-pushed
the
updates
branch
2 times, most recently
from
af17465
to
a3ff3d2
Compare
rynmrtn
approved these changes
Apr 11, 2018
There was a problem hiding this comment.
Thinking through this a bit. Only concern with removing the vendor directory is that we'll always get the latest versions of packages when make vendor is called from make test. The downside of this is that a backwards incompatible library could get in and cause tests to fail.
Positive thing is that it will catch new versions of libraries that we should be compatible with and could presumably contain bug / security fixes.
Long story short, I think it looks good
|
Also, if someone pulls in this lib, we are more or less requiring them to bring in the AWS libs with their vendoring tool of choice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.