Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding my art animrotation to the project #2560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielbarrosdevs
Copy link
Member

Please add me to the list. Thanks!

Copy link

🙏 Thanks for your pull request @danielbarrosdevs, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2560 123 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 316 3390

imageLink: './Art/danielbarrosdevs/Animrotation.gif',
author: 'Daniel',
githubLink: 'https://github.com/danielbarrosdevs'
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paths not matching contribution

./Art/danielbarrosdevs indicates your contribution lies within the folder "danielbarrosdevs" but your foldername is named "Animrotatation"
These path will need to be reviewed along with your folder name

@LaurelineP
Copy link
Contributor

LaurelineP commented Aug 26, 2024

Aloha @danielbarrosdevs 🙌
Thanks for your contribution and time !
Before we could merge your contribution, the following feedbacks need to be addressed first.
Please address the given feedbacks

Note

Checked values - are the one that are correctly done

  • Please address all the unchecked elements
  • If you need guidance , please refer to the

Tip

If the name of your folder needs to be changed ensure to adjust the include.js

📌 Feedbacks:

  • The folder name should be named after your github user name, please rename the folder accordingly
  • include.js paths does not correspond to your folder ( name / paths are different ), please adjust the path once you've reviewed the folder name

🔹 Reference Acceptance criteria for a contribution

Correctly:

  • Folder name: named after the github user name in ./Art
    • contains a HTML file: the contribution must have an HTML file
      • has a tag to the CSS file of the project
      • contains the HTML content for the animation
      • does not contain a SVG replacing the whole HTML CSS animation requirements
      • does not include any CSS library: No CSS library
      • does not contain any JS script: No JS logic should be part of your submission
    • contains a CSS file: the contribution must have a CSS file
    • the contribution includes the animated file (gif) or picture ( jpeg, jpg, png )
    • the pictural representation must not include the browser frame, just the animation
    • the contribution includes the correct contribution's details in include.js
      • the relative path should be correct : referring to the correct named folder
      • author: the value should be the github name or github
      • artName: the value should be the animation title
      • pageLink: the value should be the relative path to your project's HTML file
      • imageLink: should refer to the project relative path's image
      • githubLink: the value should be your github profile link
      • does not have chevrons
      • does not have comments for each fields

@zero-to-mastery-bot zero-to-mastery-bot bot added the Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. label Aug 26, 2024
Copy link

⚠️ MERGE CONFLICT DETECTED!

@danielbarrosdevs A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

1 similar comment
Copy link

⚠️ MERGE CONFLICT DETECTED!

@danielbarrosdevs A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

@LaurelineP LaurelineP added invalid This doesn't seem right and removed Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. labels Aug 26, 2024
@zero-to-mastery-bot zero-to-mastery-bot bot added the Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. label Aug 26, 2024
Copy link

⚠️ MERGE CONFLICT DETECTED!

@danielbarrosdevs A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

3 similar comments
Copy link

⚠️ MERGE CONFLICT DETECTED!

@danielbarrosdevs A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

Copy link

⚠️ MERGE CONFLICT DETECTED!

@danielbarrosdevs A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

Copy link

⚠️ MERGE CONFLICT DETECTED!

@danielbarrosdevs A possible conflict has been detected, you will need to resolve this before your pull request can be merged. The most common reason conflicts occur, is when the contributor does not run git pull origin master before pushing their new changes.

Before we can merge the code, you will need to resolve the conflict, check out these videos by Aldo: How To Get Started With Open Source and How To Resolve Git Merge Conflicts. If you get stuck ask over on Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested Conflict Present There is a conflict that can't be resolved in the web editor and must be resolved by the user. invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants