Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding my animation to the project #2555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

romankyv
Copy link

Hello, please add me to the list, thank you very much.

Copy link

🙏 Thanks for your pull request @romankyv, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2555 74 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 313 3386

imageLink: './Art/romankyv/BlobScale.gif',
author: 'Roman',
githubLink: 'https://github.com/romankyv'
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Case in your path

Please adjust the paths according to your folder name:

  • your folder name starts with a capital whereas your paths for your contribution here - ./Art/romankyv
    --> romankyv: start with a lowercase

@LaurelineP
Copy link
Contributor

LaurelineP commented Aug 26, 2024

Aloha @romankyv 🙌
Thanks for your contribution and time !
Before we could merge your contribution, the following feedbacks need to be addressed first.
Please address the given feedbacks

Note

Checked values - are the one that are correctly done

  • Please address all the unchecked elements
  • If you need guidance , please refer to the

Tip

If the name of your folder needs to be changed ensure to adjust the include.js

📌 Feedbacks:

  • Please review your include.js card contribution: the folder in the path is not exactly the name of your folder ( case being different )

🔹 Reference Acceptance criteria for a contribution

Correctly:

  • Folder name: named after the github user name in ./Art
    • contains a HTML file: the contribution must have an HTML file
      • has a tag to the CSS file of the project
      • contains the HTML content for the animation
      • does not contain a SVG replacing the whole HTML CSS animation requirements
      • does not include any CSS library: No CSS library
      • does not contain any JS script: No JS logic should be part of your submission
    • contains a CSS file: the contribution must have a CSS file
    • the contribution includes the animated file (gif) or picture ( jpeg, jpg, png )
    • the pictural representation must not include the browser frame, just the animation
    • the contribution includes the correct contribution's details in include.js
      • the relative path should be correct : referring to the correct named folder
      • author: the value should be the github name or github
      • artName: the value should be the animation title
      • pageLink: the value should be the relative path to your project's HTML file
      • imageLink: should refer to the project relative path's image
      • githubLink: the value should be your github profile link
      • does not have chevrons
      • does not have comments for each fields

Copy link

🙏 Thanks for your pull request @romankyv, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2555 74 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 326 3427

1 similar comment
Copy link

🙏 Thanks for your pull request @romankyv, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2555 74 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
4 326 3427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants