Fix Joomla CMS PR #26104#43
Merged
zero-24 merged 1 commit intozero-24:400minimumupdatefrom Sep 4, 2019
Merged
Conversation
Owner
|
Merging thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla#26104.
Summary of Changes
The regex to check for MariaDB is good for extracting the version number when having a MariaDB, but it is not good for checking if the DB is a MariaDB or not, because the "(mariadb-)?" part of the regex may appear zero ore one time.
It is safer to check if the version string contains mariadb (case insensitive), becaue it may appear at the beginning or at the end. The regex des not cover this.
This PR here changes it so it works the same way as in the db driver from framework 2.0-dev branch, and there it was implemented by me.
Testing Instructions
Paste the regex into an online tool and check if it matches also to a MySQL version string.
Expected result
Should not match.
Actual result
Matches.
Documentation Changes Required
None.