Prevent panic on prohibited user login with oauth2

There was an unfortunate regression in go-gitea#17962 where following detection of the UserProhibitLogin error the err is cast to a pointer by mistake. This causes a panic due to an interface error. Fix go-gitea#18561 Signed-off-by: Andrew Thornton <[email protected]>
zeripath · Feb 2, 2022 · 2984b9d · 2984b9d
1 parent 76e3111
commit 2984b9d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/routers/web/auth/oauth.go b/routers/web/auth/oauth.go
@@ -822,7 +822,7 @@ func SignInOAuthCallback(ctx *context.Context) {
 	u, gothUser, err := oAuth2UserLoginCallback(authSource, ctx.Req, ctx.Resp)
 	if err != nil {
 		if user_model.IsErrUserProhibitLogin(err) {
-			uplerr := err.(*user_model.ErrUserProhibitLogin)
+			uplerr := err.(user_model.ErrUserProhibitLogin)
 			log.Info("Failed authentication attempt for %s from %s: %v", uplerr.Name, ctx.RemoteAddr(), err)
 			ctx.Data["Title"] = ctx.Tr("auth.prohibit_login")
 			ctx.HTML(http.StatusOK, "user/auth/prohibit_login")