FEAT: merge MR #193
Merged
FEAT: merge MR #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwakitakuma33
force-pushed
the
feat/186-1
branch
2 times, most recently
from
9ad395b to
0851b5c
Compare
zereight
requested changes
Aug 3, 2025
.vscode/settings.json
Outdated
Comment on lines
1
to
4
| { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
| "editor.formatOnSave": true | ||
| } |
Owner
There was a problem hiding this comment.
Could you clarify why .vscode/settings.json was included in this PR?
Collaborator
Author
There was a problem hiding this comment.
@zereight
thanks.
that is not needed.
I deleted it.
issue: #186
iwakitakuma33
force-pushed
the
feat/186-1
branch
from
0851b5c to
20ddfa4
Compare
zereight
approved these changes
Aug 3, 2025
Owner
zereight
left a comment
zereight
left a comment
There was a problem hiding this comment.
Thank you. I always appreciate it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #186