fix zeplin component loading when zeplinLink is the same value for all stories #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the dependent variable of a hook from
zeplinLink
tostoryId
, to fix an issue where the addon cannot detect that the selected story is changed.I also changed naming of a state variable
loading
tolinksLoading
to make things more clear.loading
is also used on another state.Why?
Users can set a global
zeplinLink
parameter on.storybook/preview.js
file to load Zeplin components using Storybook integration feature of Zeplin. Story loading was dependent onzeplinLink
and it was broken due to the fact that all components share the same link. Users could not see the corresponding Zeplin components when they had clicked on a different story on the left menu, they had to refresh the page to get it.