Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zeplin component loading when zeplinLink is the same value for all stories #61

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

yuqu
Copy link
Contributor

@yuqu yuqu commented Sep 25, 2022

Description

This PR changes the dependent variable of a hook from zeplinLink to storyId, to fix an issue where the addon cannot detect that the selected story is changed.

I also changed naming of a state variable loading to linksLoading to make things more clear. loading is also used on another state.

Why?

Users can set a global zeplinLink parameter on .storybook/preview.js file to load Zeplin components using Storybook integration feature of Zeplin. Story loading was dependent on zeplinLink and it was broken due to the fact that all components share the same link. Users could not see the corresponding Zeplin components when they had clicked on a different story on the left menu, they had to refresh the page to get it.

// .storybook/preview.js file
export const parameters = {
    zeplinLink: "https://app.zeplin.io/project/61964989324da1a90c5ec217",
    ...
};

@yuqu yuqu merged commit 29ef805 into master Sep 26, 2022
@yuqu yuqu deleted the fix-coco-story-loading branch September 26, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants