USB Host: integrate class API [4: aggregated]#99775
Closed
josuah wants to merge 23 commits intozephyrproject-rtos:mainfrom
Closed
USB Host: integrate class API [4: aggregated]#99775josuah wants to merge 23 commits intozephyrproject-rtos:mainfrom
josuah wants to merge 23 commits intozephyrproject-rtos:mainfrom
Conversation
josuah
force-pushed
the
pr_usb_host_class_api4
branch
2 times, most recently
from
3f8f7bc to
2ce56b8
Compare
Contributor
|
@josuah |
josuah
changed the title
Contributor
Author
I was wondering about it: there is already two functions that seems like doing the same thing: static void dev_connected_handler(struct usbh_context *const ctx);
static void dev_removed_handler(struct usbh_context *const ctx);I will continue on the original issue. |
josuah
force-pushed
the
pr_usb_host_class_api4
branch
from
2ce56b8 to
823b5db
Compare
Contributor
|
@josuah I have updated the usb host connection/disconnection by the commit #100072. Furthermore, I also need your help to merge the commit hub_class to your API4, which this will make me easier to use newest code. Here sorry about that previously I preferred hub_class as a standalone PR. |
josuah
force-pushed
the
pr_usb_host_class_api4
branch
from
823b5db to
9506c40
Compare
josuah
force-pushed
the
pr_usb_host_class_api4
branch
7 times, most recently
from
05415e1 to
e4c6cda
Compare
josuah
force-pushed
the
pr_usb_host_class_api4
branch
from
e4c6cda to
cfde414
Compare
Add a "struct usbh_status" that contains a bitmask of flags to keep track of the global state of the host context, like done for the device_next implementation. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Add missing copyright notice for the linker script to help with check_compliance.py. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Add a "struct usbh_class_api" for the host implementation, and move all the function poitners to it. Add more fields to "struct usbh_class_data". Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Add API wrappers around the function pointers in struct usbh_class_api, while also documenting the USB host class internal API. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Add helpers to parse USB descriptors. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no> Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Add basic functions to initialize and probe class drivers. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no> Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Add functions to probe/remove all classes as part of a new usbh_class.c and a matching usbh_class.h. These functions are called from the function usbh_init_device_intl() in usbh_core.c to initialize every class upon connection of a device. Every class driver provide filters to match the interfaces of the device. Co-authored-by: Aiden Hu <weiwei.hu@nxp.com> Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Move the UVC header with all the definitions from the UVC standard to share it between USB host and device class implementation. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Make sure that there is at least enough room for the header before dereferencing the fields such as bLength. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Allocate a larger size to keep room for a nil descriptor at the end of the configuration descriptor. This is used to walk through the list of descriptors until this empty descriptor happens. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Add tests making sure the USB Host class APIs introduced build and run as expected. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Switch to the SPDX-FileCopyrightText prefix for all sources in USB Host class. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Every USB host class and platform will have to select the appropriate size for the configurtion descriptor, and the defaults will not be enough for some classes that encode a lot of information in the configuration descriptor. Add logging to debug this. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Add tests making sure the USB Host class APIs introduced build and run as expected. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Move the UVC header with all the definitions from the UVC standard to share it between USB host and device class implementation. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Move UVC helper functions to a file shared between UVC host and device. The arrays are not visible anymore from either USB host or device, but instead accessed through a front-end funciton. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
The USB control size field was wrong for UVC_PU_CONTRAST_CONTROL. Correct it to the correct value from the standard. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Loop through each of the VideoStreaming and VideoControl descriptor to parse them. This is meant as a stub for the purpose of testing the class API. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Add a test to run the USB Video Class host support by using the existing Zephyr USB Video Class device support. This allows running implementing the host side from the device side. A draft implementation of UVC is added leveraging this test. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
The public API file <zephyr/usb/class/usbd_uvc.h> lacked an include to <zephyr/drivers/video.h> making it fail depending on the order of the includes. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Allow the MAX_FRMIVAL Kconfig to be used for both device and host implementation as the header is in subsys/usb/common/. Signed-off-by: Josuah Demangeon <josuah.demangeon@nordicsemi.no>
Modify the USB device int sequence to read the device descriptor only after setting a valid device address. Signed-off-by: Santhosh Charles <santhosh@linumiz.com>
When hub is used, need to consider about multiple devices are attached. Signed-off-by: Aiden Hu <weiwei.hu@nxp.com>
josuah
force-pushed
the
pr_usb_host_class_api4
branch
from
cfde414 to
f8b0c23
Compare
|
Contributor
Author
|
Closing to make it more obvious that it is not meant to be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies:
This PR is only here to aggregate multiple other PRs together as a way to combine all "preview" features together.
It is not meant to be merged, and will stay a draft.
You might be interested in basing your PR on top of API2 or even better: directly on top of
mainIf you wish to add more commit to this PR, I would recommend to open a PR against the
mainbranch, and add a message in this thread so I can pick the commit. This way, your change can be merged directly.