Skip to content

Conversation

@dleach02
Copy link
Member

Recent addition of UVC Video encoder added sample targets to the sample without the proper filter to ensure twister didn't try to automatically build the sample target on unsupported boards.

Not all boards have the zephyr_h264enc and zephyr_h264enc in their device tree.

Fixes #98275

Recent addition of UVC Video encoder added sample targets to the sample
without the proper filter to ensure twister didn't try to automatically
build the sample target.

Not all boards have the zephyr_h264enc and zephyr_h264enc in their
device tree.

Fixes zephyrproject-rtos#98275

Signed-off-by: David Leach <[email protected]>
@zephyrbot zephyrbot added area: Samples Samples area: USB Universal Serial Bus labels Oct 27, 2025
@dleach02 dleach02 added bug The issue is a bug, or the PR is fixing a bug Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels Oct 27, 2025
@sonarqubecloud
Copy link

@hakehuang
Copy link
Contributor

regression build on all NXP platform pass

Copy link
Contributor

@JarmouniA JarmouniA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a platform_allow list, otherwise I believe it will still be built for other platforms, just without applying the extra_args.

@jhedberg jhedberg merged commit 4ea4262 into zephyrproject-rtos:main Oct 28, 2025
29 checks passed
@dleach02
Copy link
Member Author

There should be a platform_allow list, otherwise I believe it will still be built for other platforms, just without applying the extra_args.

@JarmouniA, It will only be built if the dt_chosen_enabled("zephyr,camera") is true.

@JarmouniA
Copy link
Contributor

@JarmouniA, It will only be built if the dt_chosen_enabled("zephyr,camera") is true.

Of crs, but that's not enough. The platform should have an H264/JPEG encoder for those 2 scenarios to be relevant.

@dleach02
Copy link
Member Author

@JarmouniA, It will only be built if the dt_chosen_enabled("zephyr,camera") is true.

Of crs, but that's not enough. The platform should have an H264/JPEG encoder for those 2 scenarios to be relevant.

I had a version of this PR that also added a DT filter for H264 and JPEG but twister was still failing because it generates the final DTS before doing the filter tests. So this PR reflects the change needed to allow twister to build the DTS and that ended up being all that was needed because the zephyr,camera was not enabled then in these sample targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Samples Samples area: USB Universal Serial Bus bug The issue is a bug, or the PR is fixing a bug Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

samples: samples/subsys/usb/uvc : build failure on many NXP platforms

6 participants