-
Notifications
You must be signed in to change notification settings - Fork 8.2k
samples: usb: uvc: fix target sample filters for board specific overlays #98363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Recent addition of UVC Video encoder added sample targets to the sample without the proper filter to ensure twister didn't try to automatically build the sample target. Not all boards have the zephyr_h264enc and zephyr_h264enc in their device tree. Fixes zephyrproject-rtos#98275 Signed-off-by: David Leach <[email protected]>
|
|
regression build on all NXP platform pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a platform_allow list, otherwise I believe it will still be built for other platforms, just without applying the extra_args.
@JarmouniA, It will only be built if the dt_chosen_enabled("zephyr,camera") is true. |
Of crs, but that's not enough. The platform should have an H264/JPEG encoder for those 2 scenarios to be relevant. |
I had a version of this PR that also added a DT filter for H264 and JPEG but twister was still failing because it generates the final DTS before doing the filter tests. So this PR reflects the change needed to allow twister to build the DTS and that ended up being all that was needed because the zephyr,camera was not enabled then in these sample targets. |



Recent addition of UVC Video encoder added sample targets to the sample without the proper filter to ensure twister didn't try to automatically build the sample target on unsupported boards.
Not all boards have the zephyr_h264enc and zephyr_h264enc in their device tree.
Fixes #98275