Skip to content

drivers: mipi-dbi-spi: Fix initialization of GPIO CS #98086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

drivers: mipi-dbi-spi: Fix initialization of GPIO CS #98086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions include/zephyr/drivers/mipi_dbi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,19 @@
extern "C" {
#endif

/** @cond INTERNAL_HIDDEN */
#define MIPI_DBI_DT_SPI_DEV(node_id) \
DT_PHANDLE(DT_PARENT(node_id), spi_dev)

#define MIPI_DBI_SPI_CS_GPIOS_DT_SPEC_GET(node_id) \
GPIO_DT_SPEC_GET_BY_IDX_OR(MIPI_DBI_DT_SPI_DEV(node_id), \
cs_gpios, DT_REG_ADDR_RAW(node_id), {})

#define MIPI_DBI_SPI_CS_CONTROL_INIT_GPIO(node_id, delay_) \
.gpio = MIPI_DBI_SPI_CS_GPIOS_DT_SPEC_GET(node_id), \
.delay = delay_,
/** @endcond */

/**
* @brief initialize a MIPI DBI SPI configuration struct from devicetree
*
Expand All @@ -61,12 +74,12 @@ extern "C" {
COND_CODE_1(DT_PROP(node_id, mipi_cpha), SPI_MODE_CPHA, (0)) | \
COND_CODE_1(DT_PROP(node_id, mipi_hold_cs), SPI_HOLD_ON_CS, (0)), \
.slave = DT_REG_ADDR(node_id), \
.cs = { \
COND_CODE_1(DT_SPI_DEV_HAS_CS_GPIOS(node_id), \
(SPI_CS_CONTROL_INIT_GPIO(node_id, delay_)), \
(SPI_CS_CONTROL_INIT_NATIVE(node_id))) \
.cs_is_gpio = DT_SPI_DEV_HAS_CS_GPIOS(node_id), \
}, \
.cs = { \
COND_CODE_1(DT_SPI_HAS_CS_GPIOS(MIPI_DBI_DT_SPI_DEV(node_id)), \
(MIPI_DBI_SPI_CS_CONTROL_INIT_GPIO(node_id, delay_)), \
(SPI_CS_CONTROL_INIT_NATIVE(node_id))) \
.cs_is_gpio = DT_SPI_HAS_CS_GPIOS(MIPI_DBI_DT_SPI_DEV(node_id)),\
}, \
}

/**
Expand Down