udc_dwc2: fix off-by-one in TX FIFO unset check#96804
Merged
kartben merged 1 commit intozephyrproject-rtos:mainfrom Oct 2, 2025
Merged
udc_dwc2: fix off-by-one in TX FIFO unset check#96804kartben merged 1 commit intozephyrproject-rtos:mainfrom
kartben merged 1 commit intozephyrproject-rtos:mainfrom
Conversation
Contributor
Author
|
I was only able to perform with SUCCESS |
sylvioalves
force-pushed
the
bugfix/udc_dwc2_fifo
branch
2 times, most recently
from
993e18d to
dadd2f3
Compare
Contributor
|
There is also #95654 which addresses the non 1-to-1 endpoint-to-TxFIFO mapping issue. |
Contributor
Author
@tmon-nordic, thanks! |
jfischer-no
reviewed
Oct 1, 2025
sylvioalves
force-pushed
the
bugfix/udc_dwc2_fifo
branch
from
dadd2f3 to
06a7a26
Compare
Fix the check in dwc2_unset_dedicated_fifo() that wrongly included the current endpoint when testing for higher FIFOs. This caused false warnings and early returns. Use ~BIT_MASK(ep_idx + 1) to only test FIFOs above the current EP. Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
sylvioalves
force-pushed
the
bugfix/udc_dwc2_fifo
branch
from
06a7a26 to
aeae800
Compare
|
jfischer-no
approved these changes
Oct 1, 2025
raffarost
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the check in dwc2_unset_dedicated_fifo() that wrongly included the current endpoint when testing for higher FIFOs. This caused false warnings and early returns.
Use ~BIT_MASK(ep_idx + 1) to only test FIFOs above the current EP.