drivers: xen: add SCHEDOP hypercall wrapper #95936
Conversation
soburi
force-pushed
the
xen_sched_poll
branch
2 times, most recently
from
69e2f66 to
0242b31
Compare
lorc
left a comment
lorc
left a comment
There was a problem hiding this comment.
Hi Tokita-san,
Are you sure you want to use this particular hypercall? IMO it is better to use bind_interdomain_event_channel API.
You see, Zephyr is Realtime OS, and blocking the whole vCPU to wait for one event among many can cause issues.
drivers/xen/sched.c
Outdated
| #include <zephyr/arch/arm64/hypercall.h> | ||
| #include <zephyr/xen/sched.h> | ||
|
|
||
| int sched_poll(evtchn_port_t *ports, unsigned int nr_ports, uint64_t timeout) |
There was a problem hiding this comment.
taking into account that Zephyr have no namespaces, maybe it is better to add some prefix to name of this function? xen_sched_poll() maybe?
There was a problem hiding this comment.
I fixed it.
However, as you pointed out, when I looked closely at the processing of my PR (#91605),
I found that it had already been deleted. It seems that it had been used during the development process and was still there.
It's not a bad thing to have it, but I will withdraw this PR for now to avoid increasing the number of things I need to manage.
Add SCHEDOP_poll wrapper used by Xen backends to wait on event
channels efficiently.
- sched
- sched_poll:
HYPERVISOR_sched_op(SCHEDOP_poll)
Signed-off-by: TOKITA Hiroshi <[email protected]>
soburi
force-pushed
the
xen_sched_poll
branch
from
0242b31 to
bcdedc9
Compare
|
4 participants
Add SCHEDOP_poll wrapper used by Xen backends to wait on event channels efficiently.
Note: This PR extracted from #91605