Skip to content

tests: drivers: udc: Add support for uni-directional data endpoints#94345

Open
hfakkiz wants to merge 1 commit intozephyrproject-rtos:mainfrom
analogdevicesinc:fix_udc_test
Open

tests: drivers: udc: Add support for uni-directional data endpoints#94345
hfakkiz wants to merge 1 commit intozephyrproject-rtos:mainfrom
analogdevicesinc:fix_udc_test

Conversation

@hfakkiz
Copy link
Copy Markdown
Contributor

@hfakkiz hfakkiz commented Aug 11, 2025

Devices with uni-directional data endpoints fail on "tests/drivers/udc" test. This change introduces separate IN and OUT endpoint address selection and assigns suitable endpoint addresses for each direction to ensure the test runs successfully on such devices.

@zephyrbot zephyrbot added the area: USB Universal Serial Bus label Aug 11, 2025
@sonarqubecloud
Copy link
Copy Markdown

MaureenHelm
MaureenHelm previously approved these changes Aug 19, 2025
@hfakkiz
Copy link
Copy Markdown
Contributor Author

hfakkiz commented Sep 3, 2025

@jfischer-no, @tmon-nordic Can you please visit?

Comment thread tests/drivers/udc/src/main.c Outdated
Comment thread tests/drivers/udc/src/main.c Outdated
@hfakkiz
Copy link
Copy Markdown
Contributor Author

hfakkiz commented Sep 5, 2025

I will not update this PR and will close it once #94766 is merged.

@petejohanson-adi
Copy link
Copy Markdown
Contributor

@jfischer-no We're still encountering this as 4.3.0 approaches, and given #94766 doesn't appear like it's going to make it into that release, are you open to a test-only fix similar to the ones found here, but addressing your review comments? I believe something like c05f518 is more in line with your expectations for how to handle this?

This commit adds separate selection for IN and OUT endpoint addresses.
This change allows the test to work with devices that have
uni-directional endpoints.

Signed-off-by: Furkan Akkiz <hasanfurkan.akkiz@analog.com>
Signed-off-by: Pete Johanson <pete.johanson@analog.com>
@zephyrbot zephyrbot added the area: Tests Issues related to a particular existing or missing test label Nov 5, 2025
@zephyrbot zephyrbot requested a review from nashif November 5, 2025 08:00
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Nov 5, 2025

@hfakkiz
Copy link
Copy Markdown
Contributor Author

hfakkiz commented Nov 5, 2025

@jfischer-no We're still encountering this as 4.3.0 approaches, and given #94766 doesn't appear like it's going to make it into that release, are you open to a test-only fix similar to the ones found here, but addressing your review comments? I believe something like c05f518 is more in line with your expectations for how to handle this?

Thanks Pete, I updated the PR according to your commit. It is ready for reviews.

@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@petejohanson-adi
Copy link
Copy Markdown
Contributor

Re-opening since we really still need this for testing on MAX32 to work as expected. @jfischer-no can you review please?

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Tests Issues related to a particular existing or missing test area: USB Universal Serial Bus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants