You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fs_stat() queries the root / mountpoint it should return its root i_node but instead it tries to return the parent i_node which does not exist. Fix this by checking if parent is set otherwise return the root i_node.
We need bug report for the issue and will have to generate backport. @bas-archembedded Can you log Zephyr issue for the problem you have found and reference it here as being fixed/
We need bug report for the issue and will have to generate backport. @bas-archembedded Can you log Zephyr issue for the problem you have found and reference it here as being fixed/
FYI @fzdobylak @de-nordic Not sure he will respond on this github account. It seems @fzdobylak changed jobs and does not work for AntMicro anymore and his activity on this account seems also not a lot this year.
FYI @fzdobylak @de-nordic Not sure he will respond on this github account. It seems @fzdobylak changed jobs and does not work for AntMicro anymore and his activity on this account seems also not a lot this year.
@de-nordic Shall I add the extra __ASSERT check as @cfriedt suggested, to be extra safe ?
You mean when we get args.parrent == NULL? NULL topples the device over, __ASSERT will do the same (I know that it has to be specifically compiled int...)
If it is possible, somehow, to get the NULL here I would rather return error code and refuse to work.
I am not sure failed fs_stat should bring the device down in any scenario.
When fs_stat() queries the root / mountpoint it should return its root
i_node but instead it tries to return the parent i_node which does not
exist. Fix this by checking if parent is set otherwise return the root
i_node.
Fixeszephyrproject-rtos#94000.
Signed-off-by: Bas van Loon <[email protected]>
@bas-archembedded One more thing: can you reference the bug fixed in commit message? Add the "Fixes #94000" line please.
@de-nordic Shall I add the extra __ASSERT check as @cfriedt suggested, to be extra safe ?
You mean when we get args.parrent == NULL? NULL topples the device over, __ASSERT will do the same (I know that it has to be specifically compiled int...) If it is possible, somehow, to get the NULL here I would rather return error code and refuse to work. I am not sure failed fs_stat should bring the device down in any scenario.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bas-archembedded
force-pushed
the
dev/ext2_null_ptr_fix
branch
from
de-nordic
added
backport v3.7-branch
When fs_stat() queries the root / mountpoint it should return its root i_node but instead it tries to return the parent i_node which does not exist. Fix this by checking if parent is set otherwise return the root i_node.