Skip to content

Avoid adding IPv6 RS multiple times to active timer list #88957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kartben merged 2 commits into from
Apr 25, 2025
Merged

Avoid adding IPv6 RS multiple times to active timer list #88957

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5beec0d
net: if: Make sure IPv6 RS timer is not added twice to list
jukkar Apr 23, 2025
eb17399
net: if: Stop IPv6 router solicitation if interface goes down
jukkar Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions subsys/net/ip/net_if.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1562,7 +1562,11 @@ void net_if_start_rs(struct net_if *iface)
ipv6->rs_start = k_uptime_get_32();

k_mutex_lock(&lock, K_FOREVER);

/* Make sure that the RS timer is not in the list twice */
(void)sys_slist_find_and_remove(&active_rs_timers, &ipv6->rs_node);
sys_slist_append(&active_rs_timers, &ipv6->rs_node);

k_mutex_unlock(&lock);

/* FUTURE: use schedule, not reschedule. */
Expand Down Expand Up @@ -3383,6 +3387,8 @@ static void iface_ipv6_stop(struct net_if *iface)
IF_ENABLED(CONFIG_NET_IPV6_IID_STABLE, (ipv6->network_counter++));
IF_ENABLED(CONFIG_NET_IPV6_IID_STABLE, (ipv6->iid = NULL));

net_if_stop_rs(iface);

/* Remove all autoconf addresses */
ARRAY_FOR_EACH(ipv6->unicast, i) {
if (ipv6->unicast[i].is_used &&
Expand Down