Skip to content

Conversation

@AlessandroLuo
Copy link
Contributor

Keep minimal system in board dts, only enable driver in overlays

@AlessandroLuo AlessandroLuo requested a review from Copilot April 23, 2025 07:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (17)
  • boards/ambiq/apollo3_evb/apollo3_evb.dts: Language not supported
  • boards/ambiq/apollo3p_evb/apollo3p_evb.dts: Language not supported
  • boards/ambiq/apollo4p_blue_kxr_evb/apollo4p_blue_kxr_evb.dts: Language not supported
  • boards/ambiq/apollo4p_evb/apollo4p_evb.dts: Language not supported
  • samples/drivers/counter/alarm/boards/apollo3_evb.overlay: Language not supported
  • samples/drivers/counter/alarm/boards/apollo3p_evb.overlay: Language not supported
  • samples/drivers/counter/alarm/boards/apollo4p_blue_kxr_evb.overlay: Language not supported
  • samples/drivers/counter/alarm/boards/apollo4p_evb.overlay: Language not supported
  • samples/drivers/rtc/boards/apollo3_evb.overlay: Language not supported
  • samples/drivers/rtc/boards/apollo3p_evb.overlay: Language not supported
  • samples/subsys/fs/fs_sample/boards/apollo4p_evb.overlay: Language not supported
  • tests/drivers/counter/counter_basic_api/boards/apollo3_evb.overlay: Language not supported
  • tests/drivers/counter/counter_basic_api/boards/apollo3p_evb.overlay: Language not supported
  • tests/drivers/counter/counter_basic_api/boards/apollo4p_blue_kxr_evb.overlay: Language not supported
  • tests/drivers/counter/counter_basic_api/boards/apollo4p_evb.overlay: Language not supported
  • tests/drivers/rtc/rtc_api/boards/apollo3_evb.overlay: Language not supported
  • tests/drivers/rtc/rtc_api/boards/apollo4p_evb.overlay: Language not supported

@AlessandroLuo AlessandroLuo force-pushed the ambiq-board-disable branch 4 times, most recently from e0c00b5 to 2105cbe Compare April 24, 2025 01:46
@github-actions
Copy link

github-actions bot commented Apr 24, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_ambiq zephyrproject-rtos/hal_ambiq@e916e84 zephyrproject-rtos/hal_ambiq@9da9656 (main) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Keep minimal system in board dts, only enable driver in overlays

Signed-off-by: Hao Luo <[email protected]>
Copy link
Contributor

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fs sample overlay looks ok

Copy link
Contributor

@RichardSWheatley RichardSWheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlessandroLuo
Copy link
Contributor Author

@kartben please help to merge this PR, thanks!

@kartben kartben merged commit 6603908 into zephyrproject-rtos:main May 5, 2025
31 checks passed
@AlessandroLuo AlessandroLuo deleted the ambiq-board-disable branch May 8, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants