Bluetooth: Controller: Only validate CIS SDU interval for BN > 0 #88939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
carlescufi,
cvinayak,
erbr-ot,
thoh-ot and
wopu-ot
cvinayak
previously approved these changes
Apr 24, 2025
Comment on lines
+352
to
+358
| if ((pdu->llctrl.cis_req.c_bn > 0 && c_sdu_interval < BT_HCI_ISO_SDU_INTERVAL_MIN) || | ||
| (pdu->llctrl.cis_req.p_bn > 0 && p_sdu_interval < BT_HCI_ISO_SDU_INTERVAL_MIN)) { |
There was a problem hiding this comment.
Suggested change
| if ((pdu->llctrl.cis_req.c_bn > 0 && c_sdu_interval < BT_HCI_ISO_SDU_INTERVAL_MIN) || | |
| (pdu->llctrl.cis_req.p_bn > 0 && p_sdu_interval < BT_HCI_ISO_SDU_INTERVAL_MIN)) { | |
| /* | |
| Some in the-wild devices use SDU interval of 0 when BN == 0; This | |
| is not allowed by BT Core Spec v6.0, but is not specifically | |
| mentioned in v5.4 and earlier. To allow connecting a CIS to these | |
| devices, relax the check on SDU interval | |
| */ | |
| if ((pdu->llctrl.cis_req.c_bn > 0 && c_sdu_interval < BT_HCI_ISO_SDU_INTERVAL_MIN) || | |
| (pdu->llctrl.cis_req.p_bn > 0 && p_sdu_interval < BT_HCI_ISO_SDU_INTERVAL_MIN)) { |
Some in-the-wild devices use SDU interval of 0 when BN == 0; This is not allowed by BT Core Spec v6.0, but is not specifically mentioned in v5.4 and earlier. To allow connecting a CIS to these devices, relax the check on SDU interval Note: LL/CIS/PER/BI-07-C only checks rejection of invalid SDU interval with BN > 0, so it still passes with this change Signed-off-by: Troels Nilsson <[email protected]>
Tronil
force-pushed
the
only-validate-SDU-int-if-bn-not-0
branch
from
75f2764 to
3d94426
Compare
erbr-ot
approved these changes
Apr 25, 2025
cvinayak
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some in the-wild devices use SDU interval of 0 when BN == 0; This is not allowed by BT Core Spec v6.0, but is not specifically mentioned in v5.4 and earlier. To allow connecting a CIS to these devices, relax the check on SDU interval
Note: LL/CIS/PER/BI-07-C only checks rejection of invalid SDU interval with BN > 0, so it still passes with this change