Add driver for the Infineon S25H NOR flash#88446
Closed
m-braunschweig wants to merge 5 commits intozephyrproject-rtos:mainfrom
Closed
Add driver for the Infineon S25H NOR flash#88446m-braunschweig wants to merge 5 commits intozephyrproject-rtos:mainfrom
m-braunschweig wants to merge 5 commits intozephyrproject-rtos:mainfrom
Conversation
Add a infineon s25h mspi nor flash driver. This driver was tested on the am243x-lp board in 1S-1S-1S mode. The driver doesn't check the configuration for dummy cycles and assumes a factory default configuration. It also changes, if needed, a non-volatile configuration bit so the erase sectors are uniform. On startup the JEDEC id is read and checked as basic communication test. Signed-off-by: Mika Braunschweig <mika.braunschweig@siemens.com>
Until now the Infineon S25H driver ran MSPI only in single IO mode. With this change the driver now switches the IO mode to Quad SPI at the end of the initialization for higher transfer rates Signed-off-by: Mika Braunschweig <mika.braunschweig@siemens.com>
The Infineon S25H driver requires the hybrid sectory architecture to be disabled. For better readability this code has been moved into an own function that is now called from the init function Signed-off-by: Mika Braunschweig <mika.braunschweig@siemens.com>
To be able to address the full flash memory it's required to enter the 4 byte address mode. This is now done automatically during startup Signed-off-by: Mika Braunschweig <mika.braunschweig@siemens.com>
The s25h has a continous read mode that can be accidentially triggered, if the address ends with a special bit pattern and the MSPI controller has a high impedance state. To avoid this scenario it used to be forbidden to do non-aligned reads. This has now changed by reading the JEDEC id after a non-aligned read to instead break the precondition for a continious read. Signed-off-by: Mika Braunschweig <mika.braunschweig@siemens.com>
github-actions
Bot
added
area: MSPI
area: Flash
platform: Infineon
github-actions
Bot
requested review from
de-nordic,
ifyall,
npal-cy,
rghaddab,
swift-tk and
talih0
Contributor
|
Hi @m-braunschweig It might be best to include the driver in the same PR where MSPI driver support is #88487 |
Contributor
Author
|
My idea was to keep the PRs small for faster review and since I do development/testing on the linked branch and then only cherry-pick the commits for the Pull Requests I think it should be fine |
Contributor
Author
|
As suggested it's now part of #88487 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This driver adds support for the Infineon S25H NOR flash.
The changes were tested in combination of these changes and should only be merged after there is support for the AM243x launchpad and it's MSPI driver.
However I would still like some early review, especially since there now is a generic MSPI NOR driver (which wasn't merged when I started writing this driver) but it doesn't seem like it's possible to cleanly implement the disabling of the hybrid sector mode and the continous read feature might be a problem.