drivers: video: gc2145: Fix output format. #85491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iabdalkader
force-pushed
the
gc2145_fix_fmt
branch
from
5bb9a25 to
4e0dd9b
Compare
josuah
previously approved these changes
Feb 10, 2025
Contributor
josuah
left a comment
josuah
left a comment
There was a problem hiding this comment.
The bugfix LGTM. Thank you!
Comment on lines
-83
to
+85
| {GC2145_REG_OUTPUT_FMT, 0x14}, /* Analog Mode 1 (vflip/mirror[1:0]) */ | ||
| {0x18, 0x22}, /* Analog Mode 2 */ | ||
| {0x17, 0x14}, /* Analog Mode 1 (vflip/mirror[1:0]) */ | ||
| {0x18, 0x22}, /* Analog Mode 2 */ |
Contributor
There was a problem hiding this comment.
That is right... Good catch!
- Fix analog mode register address. - Fix output format register update. Signed-off-by: Ibrahim Abdalkader <[email protected]>
iabdalkader
force-pushed
the
gc2145_fix_fmt
branch
from
4e0dd9b to
19d0440
Compare
josuah
approved these changes
Feb 11, 2025
ngphibang
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you look closely you'll see that the RGB565 colors are actually wrong.