[Backport v2.7-branch] DNS parsing issues #82392
Open
+57
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaiJuWu
requested review from
rlubos,
tbursztyka,
pfalcon and
cfriedt
as code owners
github-actions
bot
added
area: Networking
area: Tests
jukkar
approved these changes
Dec 2, 2024
rlubos
approved these changes
Dec 2, 2024
cfriedt
approved these changes
Dec 2, 2024
|
Edit: never mind, missed the created issue |
After that issue is resolved, I will rebase code to re-trigger CI. |
TaiJuWu
force-pushed
the
backport-82072-to-v2.7-branch
branch
from
84936ba to
0b7e8c5
Compare
|
@kartben - any idea why the doc build is failing in this PR? |
Will have a look (my) tomorrow -- prob need to "freeze" requirements-doc.txt a bit more than it currently is 🥶 |
If the packet parsing fails in dns_unpack_response_query(), then do not continue further but bail out early. Signed-off-by: Jukka Rissanen <[email protected]>
Make sure we test malformed packet parsing. Signed-off-by: Jukka Rissanen <[email protected]>
Make sure that when copying the qname, the source buffer is large enough for the data. Signed-off-by: Jukka Rissanen <[email protected]>
The dns_unpack_answer() did not check the length of the message properly which can cause out of bounds read. Signed-off-by: Jukka Rissanen <[email protected]>
Make sure we catch invalid answer during parsing. Signed-off-by: Jukka Rissanen <[email protected]>
TaiJuWu
force-pushed
the
backport-82072-to-v2.7-branch
branch
from
0b7e8c5 to
262cd26
Compare
|
relevant issue -- pypa/setuptools#4478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #82072 to v2.7
Fixes #82139