Skip to content

drivers: wifi: infineon: Add SPI support to AIROC WiFi driver #78773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 10, 2024
Merged

drivers: wifi: infineon: Add SPI support to AIROC WiFi driver #78773

merged 4 commits into from
Dec 10, 2024

Conversation

@ThreeEights
Copy link
Contributor

@ThreeEights ThreeEights commented Sep 20, 2024

Added support for SPI to the Infineon AIROC WiFi driver (drivers/wifi/infineon). Includes support for 3-wire SPI required by the Raspberry Pi Pico W.

Configuration for the Pico W is updated to activate the WiFi chip on that board.

@zephyrbot zephyrbot added platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) platform: Infineon Infineon Technologies AG area: Wi-Fi Wi-Fi labels Sep 20, 2024
parthitce
parthitce requested changes Sep 21, 2024
View reviewed changes
Copy link
Member

@parthitce parthitce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split the changes. bindings, driver and consumer

soburi
soburi reviewed Sep 21, 2024
View reviewed changes
soburi
soburi reviewed Sep 21, 2024
View reviewed changes
@soburi soburi mentioned this pull request Sep 23, 2024
Open
57 tasks
@ThreeEights ThreeEights force-pushed the airoc-spi-wifi branch 2 times, most recently from 6b1db29 to f41933d Compare September 23, 2024 15:44
@ThreeEights
Copy link
Contributor Author

ThreeEights commented Sep 23, 2024

@parthitce - You wrote "split the changes. bindings, driver and consumer". Do you mean create 3 separate pull requests? Or do you mean something else?

@parthitce
Copy link
Member

parthitce commented Sep 24, 2024

@parthitce - You wrote "split the changes. bindings, driver and consumer". Do you mean create 3 separate pull requests? Or do you mean something else?

No, split into multiple commits in this PR

@ThreeEights
Copy link
Contributor Author

ThreeEights commented Sep 24, 2024 •
edited
Loading

@parthitce - I divided this into 3 commits as you requested. Please let me know if these meet your expectations.

Unfortunately, these changes depend on a pull request for modules/hal/infineon, which is still being reviewed by Infineon. I'll keep following that change so this can proceed. That change is done - the new commit is [7b420b9], now part of this pull request).

soburi
soburi reviewed Sep 27, 2024
View reviewed changes
npal-cy
npal-cy suggested changes Sep 27, 2024
View reviewed changes
@zephyrbot
Copy link

zephyrbot commented Sep 30, 2024 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_infineon zephyrproject-rtos/hal_infineon@88d2529 zephyrproject-rtos/hal_infineon@a9b75e0 (master) zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

ajf58
ajf58 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@ajf58 ajf58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

All my comments/suggestions have been answered and/or corrected. I spotted a couple of tiny tweaks (sorry I didn't spot them earlier), but definitely should not blocker such a significant improvement to in-tree functionality for this board.

@kartben kartben linked an issue Dec 3, 2024 that may be closed by this pull request
drivers: wifi: Infineon AIROC: Add SPI support #67092
Closed
@ThreeEights ThreeEights mentioned this pull request Dec 3, 2024
Closed
@jukkar
Copy link
Member

jukkar commented Dec 3, 2024

@parthitce @npal-cy please re-review

npal-cy
npal-cy reviewed Dec 4, 2024
View reviewed changes
@ThreeEights ThreeEights requested review from ajf58 and npal-cy December 4, 2024 15:13
parthitce
parthitce approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@parthitce parthitce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures needs to be addressed. Otherwise LGTM

@ThreeEights
Copy link
Contributor Author

ThreeEights commented Dec 5, 2024

@parthitce - Thank you!

@ifyall
Copy link
Contributor

ifyall commented Dec 5, 2024

@ThreeEights, I am just waiting on some functional tests from my team on the existing Wi-Fi support with this change. Once that is done and is passing, I will approve.

Ian

@ThreeEights
Copy link
Contributor Author

ThreeEights commented Dec 5, 2024

@ifyall - Thanks!

@ThreeEights
dts: bindings: wifi: Support SPI for Infineon AIROC driver
6d7c6f2 
Additional bindings to configure SPI support.

Added new DTS option for data/IRQ sharing
Clarify default in driver DTS binding

Signed-off-by: Steve Boylan <[email protected]>
@ThreeEights
drivers: wifi: infineon: Add SPI support to AIROC driver
9dcc459 
Added support for SPI in 4-wire and 3-wire configurations to
the Infineon AIROC WiFi driver (drivers/wifi/infineon).

Review changes:
Move DT_DRV_COMPAT to common header file
Correct board-specific preprocessor lines
Removed AIROC_MAP_COUNTRY_CODE
Move Pico W configuration details to devicetree
Use pinctrl to manage shared data/interrupt GPIO
Clean up bus selection in Kconfig.airoc
Make SDIO and SPI bus struct independent
Replace LOG_DBG with LOG_ERR
Remove functionally duplicate operation
Remove spurious Kconfig option
Minor cleanup in CMakeLists.txt

Signed-off-by: Steve Boylan <[email protected]>
@ThreeEights
boards: rpi_pico: WiFi configuration for Pico W
4d0bd9a 
Configure the Raspberry Pi Pico W for WiFi.
Move Pico W configuration details to devicetree
Add pinctrl configurations for data/interrupt sharing
Make memory config selectable
Align devicetree with Linux ordering

Signed-off-by: Steve Boylan <[email protected]>
@ThreeEights
manifest: Update hal_infineon to latest version
35d8d0f 
Adds custom HAL support for SPI

Signed-off-by: Steve Boylan <[email protected]>
@jukkar
Copy link
Member

jukkar commented Dec 9, 2024

ping @npal-cy please take a look

@npal-cy
Copy link
Contributor

npal-cy commented Dec 10, 2024 •
edited
Loading

ping @npal-cy please take a look

I am going to do some tests today, before merge...

@fabiobaltieri fabiobaltieri assigned npal-cy and unassigned jukkar Dec 10, 2024
@kartben kartben merged commit 95969f5 into zephyrproject-rtos:main Dec 10, 2024
29 checks passed
@kartben
Copy link
Contributor

kartben commented Dec 10, 2024

Yay!!! Thanks for the hard work @ThreeEights!

@ThreeEights
Copy link
Contributor Author

ThreeEights commented Dec 10, 2024

@ifyall @npal-cy @yonsch @parthitce @kartben @jukkar @soburi @ajf58 - Thanks for all your help making this clean and functional.

@soburi soburi mentioned this pull request Jan 28, 2025
Merged
@ThreeEights ThreeEights mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soburi soburi soburi approved these changes

@jukkar jukkar jukkar approved these changes

@parthitce parthitce parthitce approved these changes

@ifyall ifyall Awaiting requested review from ifyall

@Kludentwo Kludentwo Awaiting requested review from Kludentwo

@krish2718 krish2718 Awaiting requested review from krish2718

@rlubos rlubos Awaiting requested review from rlubos

@talih0 talih0 Awaiting requested review from talih0

@yonsch yonsch Awaiting requested review from yonsch

@kartben kartben Awaiting requested review from kartben

@MaochenWang1 MaochenWang1 Awaiting requested review from MaochenWang1

@ajf58 ajf58 Awaiting requested review from ajf58

+1 more reviewer

@npal-cy npal-cy npal-cy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@npal-cy npal-cy

Labels

area: Wi-Fi Wi-Fi manifest manifest-hal_infineon platform: Infineon Infineon Technologies AG platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

drivers: wifi: Infineon AIROC: Add SPI support

9 participants

@ThreeEights @parthitce @zephyrbot @kartben @jukkar @ifyall @npal-cy @soburi @ajf58