Backport 3.6: zephyr: Add zero-len check for utf8_trunc #78286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function did not check if the provided string had a zero length before starting to truncate, which meant that last_byte_p could possible have pointed to the value before the string. Signed-off-by: Emil Gydesen <[email protected]>
This was
linked to
issues
Sep 11, 2024
zephyrbot
requested review from
aaronemassey,
andyross,
asemjonovs,
dcpleung,
jeremybettis,
nashif,
peter-mitsis and
yperess
nashif
changed the title
|
The backport fails testing due to relying on some test functions added by #73841 Should I also backport the test functions, or should I just remove the test from the backport? |
|
@ceolin @henrikbrixandersen what do you suggest for the failing tests? Pull in the test dependencies, or remove the test? |
ceolin
previously approved these changes
Sep 13, 2024
|
@Thalley imho just the fix is enough. |
Either is fine by me, but the simpler solution would be to not backport the tests. |
Thalley
force-pushed
the
backport-74949-to-v3.6-branch
branch
from
9d6ff14 to
1818d7a
Compare
|
Removed the test |
henrikbrixandersen
approved these changes
Sep 16, 2024
MaureenHelm
approved these changes
Sep 16, 2024
nashif
approved these changes
Sep 18, 2024
henrikbrixandersen
merged commit 2c2540e
into
zephyrproject-rtos:v3.6-branch
17 checks passed
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #74949
Fixes: #77956
Fixes: #77957