-
Notifications
You must be signed in to change notification settings - Fork 8.2k
board: Adding Adafruit QT PY RP2040 Support #66603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
board: Adding Adafruit QT PY RP2040 Support #66603
Conversation
e6264fd to
089e58e
Compare
yonsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no familiarity with the boards but it seems OK. I only have one small remark regarding formatting.
Regarding the commits, they will have to be structured differently. On a quick glance I'd say one commit for adding the board and one commit for adding the test overlay. You can have the mutual commit be signed off by both @hlord2000 and yourself.
Two questions, just to make sure:
- Have you tested this on actual hardware (more specifically, after rebasing it on a fresh main to get the clock control patch)?
- Does this replace #63554 completely? Can we close it afterwards?
I'll restructure all of the commits into 2 commits, the first being the changes of the "boards" directory (signed off by both of us), and the second would be just the change to "tests" directory.
|
Adding support for the Adafruit QT PY RP2040. Signed-off-by: Kelly Helmut Lord <[email protected]> Signed-off-by: Ian Wakely <[email protected]>
Adding a board overlay for the ADC API driver test. Signed-off-by: Ian Wakely <[email protected]>
8e0291b to
032cd6d
Compare
yonsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
soburi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Hi @raveious! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
Adding a board option for the Adafruit QT PY - RP2040 variant.
Supersedes #63554