Skip to content

Conversation

@raveious
Copy link
Contributor

Adding a board option for the Adafruit QT PY - RP2040 variant.

Supersedes #63554

@zephyrbot zephyrbot added the area: ADC Analog-to-Digital Converter (ADC) label Dec 17, 2023
@zephyrbot zephyrbot requested a review from anangl December 17, 2023 03:10
@nordicjm nordicjm requested review from soburi and yonsch December 18, 2023 07:38
@raveious
Copy link
Contributor Author

@anangl @soburi @yonsch Would you mind reviewing this?

@raveious raveious force-pushed the adafruit_qt_py_rp2040 branch from e6264fd to 089e58e Compare December 21, 2023 03:37
Copy link
Contributor

@yonsch yonsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no familiarity with the boards but it seems OK. I only have one small remark regarding formatting.
Regarding the commits, they will have to be structured differently. On a quick glance I'd say one commit for adding the board and one commit for adding the test overlay. You can have the mutual commit be signed off by both @hlord2000 and yourself.
Two questions, just to make sure:

  1. Have you tested this on actual hardware (more specifically, after rebasing it on a fresh main to get the clock control patch)?
  2. Does this replace #63554 completely? Can we close it afterwards?

@raveious
Copy link
Contributor Author

I have no familiarity with the boards but it seems OK. I only have one small remark regarding formatting. Regarding the commits, they will have to be structured differently. On a quick glance I'd say one commit for adding the board and one commit for adding the test overlay. You can have the mutual commit be signed off by both @hlord2000 and yourself. Two questions, just to make sure:

  1. Have you tested this on actual hardware (more specifically, after rebasing it on a fresh main to get the clock control patch)?
  2. Does this replace boards: add support for QT Py RP2040 #63554 completely? Can we close it afterwards?

I'll restructure all of the commits into 2 commits, the first being the changes of the "boards" directory (signed off by both of us), and the second would be just the change to "tests" directory.

  1. Yes, I have tested it on actual hardware. I've tested this with the "hello_world" and "usb_console" samples, and everything works as intended. Is there anything else you would like me to try?
  2. Yes, this would replace that PR completely. The other one appeared stale and unmaintained. When making comments on the PR, the author said it was ok to open a new PR with the actions addressed.

hlord2000 and others added 2 commits December 21, 2023 11:04
Adding support for the Adafruit QT PY RP2040.

Signed-off-by: Kelly Helmut Lord <[email protected]>
Signed-off-by: Ian Wakely <[email protected]>
Adding a board overlay for the ADC API driver test.

Signed-off-by: Ian Wakely <[email protected]>
@raveious raveious force-pushed the adafruit_qt_py_rp2040 branch from 8e0291b to 032cd6d Compare December 21, 2023 16:08
Copy link
Contributor

@yonsch yonsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@soburi soburi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlescufi carlescufi merged commit 9835957 into zephyrproject-rtos:main Dec 22, 2023
@github-actions
Copy link

Hi @raveious!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@raveious raveious deleted the adafruit_qt_py_rp2040 branch December 25, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ADC Analog-to-Digital Converter (ADC)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants