drivers: ieee802154_nrf5: Add payload length check on TX #60528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case upper layer does not follow the convention, and the net_pkt provided to the nRF 15.4 driver had a payload larger than the maximum payload size of an individual 15.4 frame, the driver would end up with buffer overflow. Fix this by adding an extra payload_len check before attempting to copy the payload to the internal buffer. Signed-off-by: Robert Lubos <[email protected]>
jukkar
previously approved these changes
Jul 18, 2023
ghost
previously approved these changes
Jul 18, 2023
drivers/ieee802154/ieee802154_nrf5.c
Outdated
| uint8_t *payload = frag->data; | ||
| bool ret = true; | ||
|
|
||
| if (payload_len > NRF5_PSDU_LENGTH) { |
There was a problem hiding this comment.
Maybe this is a good opportunity to switch to IEEE802154_MTU instead everywhere and remove that custom constant which seems to be redundant? (of course not required at all - just an idea)
There was a problem hiding this comment.
I've removed the redefined constants and switched to use symbols defined in ieee802154.h header, where applicable in the driver.
jciupis
previously approved these changes
Jul 19, 2023
Use generic symbols defined in ieee802154.h for packet/FCS size instead of redefining them in the driver header. Signed-off-by: Robert Lubos <[email protected]>
jciupis
approved these changes
Jul 19, 2023
ghost
approved these changes
Jul 19, 2023
jukkar
approved these changes
Jul 19, 2023
cfriedt
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case upper layer does not follow the convention, and the net_pkt provided to the nRF 15.4 driver had a payload larger than the maximum payload size of an individual 15.4 frame, the driver would end up with buffer overflow.
Fix this by adding an extra payload_len check before attempting to copy the payload to the internal buffer.