Skip to content

drivers: sensors: Add support for RaspberryPi Pico CPU temperature #53591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2023
Merged

drivers: sensors: Add support for RaspberryPi Pico CPU temperature #53591

merged 2 commits into from
Jan 19, 2023

Conversation

@soburi
Copy link
Member

@soburi soburi commented Jan 9, 2023

Support for the measuring the CPU die temperature
for the RaspberryPi Pico.

Signed-off-by: TOKITA Hiroshi [email protected]

@zephyrbot zephyrbot added area: Sensors Sensors area: Devicetree Binding PR modifies or adds a Device Tree binding labels Jan 9, 2023
@zephyrbot zephyrbot requested review from avisconti and teburd January 9, 2023 03:40
@soburi soburi added the platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) label Jan 9, 2023
yonsch
yonsch requested changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@yonsch yonsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left a few comments

MaureenHelm
MaureenHelm reviewed Jan 9, 2023
View reviewed changes
samples/sensor/cpu_temp_polling/boards/rpi_pico.overlay Outdated
Comment on lines 7 to 9
Copy link
Member

@MaureenHelm MaureenHelm Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you implemented this as an overlay instead of doing it in the board dts?

Copy link
Member Author

@soburi soburi Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aliase clause move to rp2040.dts.
Still default disabled the die-temp node.
So keeping remain the overlay for enabling it.

MaureenHelm
MaureenHelm requested changes Jan 10, 2023
View reviewed changes
drivers/sensor/rpi_pico_temp/Kconfig Outdated
Copy link
Member

@MaureenHelm MaureenHelm Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already have a dependency on the dts compatible, so I think you can remove the redundant dependency on the SOC_SERIES

Copy link
Member Author

@soburi soburi Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It make a sense.
Removed SOC_SERIES_RP2XXX.

dts/bindings/sensor/raspberrrypi,pico-temp.yaml Outdated
Copy link
Member

@MaureenHelm MaureenHelm Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please justify the default value in the description

Copy link
Member Author

@soburi soburi Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add short description for clarify it is a spec.

dts/bindings/sensor/raspberrrypi,pico-temp.yaml Outdated
Copy link
Member

@MaureenHelm MaureenHelm Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please justify the default value in the description

Copy link
Member Author

@soburi soburi Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add short description for clarify it is a spec.

yonsch
yonsch previously approved these changes Jan 11, 2023
View reviewed changes
@soburi soburi requested a review from MaureenHelm January 11, 2023 12:41
yonsch
yonsch previously approved these changes Jan 12, 2023
View reviewed changes
MaureenHelm
MaureenHelm requested changes Jan 12, 2023
View reviewed changes
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rename the dts alias and sample to be consistent with the sensor channel name? i.e., die temp instead of cpu temp

@soburi
drivers: sensors: Add support for RaspberryPi Pico CPU temperature
5b52b6f 
Support for the measuring the CPU die temperature
for the RaspberryPi Pico.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi soburi requested review from MaureenHelm and yonsch January 12, 2023 23:02
@soburi
Copy link
Member Author

soburi commented Jan 12, 2023

@MaureenHelm

Can you please rename the dts alias and sample to be consistent with the sensor channel name? i.e., die temp instead of cpu temp

Renamed to die-temp[n].

yonsch
yonsch previously approved these changes Jan 13, 2023
View reviewed changes
MaureenHelm
MaureenHelm requested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rename the dts alias and sample to be consistent with the sensor channel name? i.e., die temp instead of cpu temp

Renamed to die-temp[n].

The sample filenames need to be renamed too

@soburi
samples: sensor: Add CPU temperature monitor sample
56f09e0 
Add a polling sample for CPU temperature monitor.
This sample demonstrates how to data fetch and print to the console.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi
Copy link
Member Author

soburi commented Jan 14, 2023

@MaureenHelm

The sample filenames need to be renamed too
Fix done.

@soburi soburi requested a review from MaureenHelm January 14, 2023 15:53
@soburi soburi mentioned this pull request Jan 16, 2023
Open
57 tasks
@MaureenHelm MaureenHelm merged commit b70d399 into zephyrproject-rtos:main Jan 19, 2023
@soburi soburi deleted the pico_cpu_temp branch January 19, 2023 22:32
soburi added a commit to soburi/zephyr that referenced this pull request Aug 2, 2023
@soburi
CODEOWNERS: add codeowner of rpi_pico_temp
16ad04b 
Add myself as codeowner of previously committed driver.

- zephyrproject-rtos#53591

Signed-off-by: TOKITA Hiroshi <[email protected]>
fabiobaltieri pushed a commit that referenced this pull request Aug 3, 2023
@soburi @fabiobaltieri
CODEOWNERS: add codeowner of rpi_pico_temp
e753d76 
Add myself as codeowner of previously committed driver.

- #53591

Signed-off-by: TOKITA Hiroshi <[email protected]>
kunoh pushed a commit to kunoh/zephyr that referenced this pull request Aug 7, 2023
@soburi @kunoh
CODEOWNERS: add codeowner of rpi_pico_temp
f792130 
Add myself as codeowner of previously committed driver.

- zephyrproject-rtos#53591

Signed-off-by: TOKITA Hiroshi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@yonsch yonsch yonsch approved these changes

@nashif nashif Awaiting requested review from nashif

@galak galak Awaiting requested review from galak

@avisconti avisconti Awaiting requested review from avisconti

@teburd teburd Awaiting requested review from teburd

Assignees

@MaureenHelm MaureenHelm

Labels

area: Devicetree Binding PR modifies or adds a Device Tree binding area: Sensors Sensors platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@soburi @MaureenHelm @yonsch @zephyrbot