Skip to content

manifest: update hal_nxp to fix ARRAY_SIZE collision #51372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2022
Merged

manifest: update hal_nxp to fix ARRAY_SIZE collision #51372

merged 1 commit into from
Oct 20, 2022

Conversation

@gmarull
Copy link
Member

@gmarull gmarull commented Oct 18, 2022

Updated hal_nxp so that it uses MIN/MAX/ARRAY_SIZE defined in <zephyr/sys/util.h> when built for Zephyr.

Fixes #51371

Signed-off-by: Gerard Marull-Paretas [email protected]

@gmarull gmarull force-pushed the hal-nxp-array-size branch from bcc753d to 1d5578d Compare October 18, 2022 10:59
@zephyrbot zephyrbot added manifest west manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Oct 18, 2022
@zephyrbot
Copy link

zephyrbot commented Oct 18, 2022 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@3e36485 zephyrproject-rtos/hal_nxp@9bc1e79 (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@gmarull gmarull requested a review from stephanosio October 19, 2022 09:01
desowin
desowin previously approved these changes Oct 19, 2022
View reviewed changes
Copy link

@desowin desowin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solves twister build issue seen in #50856

@gmarull
manifest: update hal_nxp to fix ARRAY_SIZE collision
8725e94 
Updated hal_nxp so that it uses MIN/MAX/ARRAY_SIZE defined in
<zephyr/sys/util.h> when built for Zephyr. Also removed KB() internal
definition from public headers.

Signed-off-by: Gerard Marull-Paretas <[email protected]>
@gmarull gmarull force-pushed the hal-nxp-array-size branch from 1d5578d to 8725e94 Compare October 20, 2022 15:06
@gmarull gmarull requested a review from carlescufi October 20, 2022 15:06
@gmarull
Copy link
Member Author

gmarull commented Oct 20, 2022

updated sha

@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Oct 20, 2022
@gmarull gmarull added the Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. label Oct 20, 2022
@carlescufi carlescufi merged commit a139805 into zephyrproject-rtos:main Oct 20, 2022
@gmarull gmarull deleted the hal-nxp-array-size branch October 20, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephanosio stephanosio stephanosio approved these changes

@carlescufi carlescufi carlescufi approved these changes

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@dleach02 dleach02 Awaiting requested review from dleach02

+1 more reviewer

@desowin desowin desowin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. manifest manifest-hal_nxp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hal: nxp: ARRAY_SIZE collision

5 participants

@gmarull @zephyrbot @desowin @stephanosio @carlescufi